1499326 - Remove custom styling for cert error pages with browser.xul.error_pages.expert_bad_cert

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P3)

Description

[Johann Hofmann [:johannh]]

I found this piece of code:

https://searchfox.org/mozilla-central/rev/3a54520d8d2319a4116866371ed3d9ed2ec0cc2b/browser/base/content/aboutNetError.js#213-225

Apparently this is for customizing the cert error page in case the browser.xul.error_pages.expert_bad_cert is flipped.

Is there anyone actually using it for some reason? Can we remove this functionality?

Comment 1

[Mike Kaply [:mkaply]]

I don't advertise it for enterprise or know of anyone that uses it.

For more background:

http://kb.mozillazine.org/Browser.xul.error_pages.expert_bad_cert

If we remove it, we need to update here as well:

https://developer.mozilla.org/en-US/docs/Mozilla/Preferences/Mozilla_preferences_for_uber-geeks

Comment 2

[Johann Hofmann [:johannh]]

Well, even these pages only say that expert_bad_cert will show the advanced panel by default. There's no mention of some custom styling. It seems like we can remove it.

Comment 3

[Manish [:manishkk]]

Attachment: Bug 1499326 - Remove custom styling for cert error pages with browser.xul.error_pages.expert_bad_cert r?johannh

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fee0a53015fb
Remove custom styling for cert error pages with browser.xul.error_pages.expert_bad_cert r=johannh

Comment 5

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fee0a53015fb