1497448 - [remote-dbg-next] Show proper content after disabling "Remote debugging via USB" on Firefox in Android

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Daisuke Akatsuka (:daisuke)]

STRs:
1. Connect and select a USB device in sidebar
2. Disable "Remote debugging via USB" switch on Firefox in Android
3. Add a tab on Firefox in Android

ER:
When disable the remote debugging, should show another content in main page, and hide the device item from sidebar.

AR:
We could see the added tab in the runtime page.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Close all connections of USB when devtools.remote.usb.enabled is disabled. r=jdescottes!

If "devtools.remote.usb.enabled" will be disabled on Android, denies from new
connection, but retains connections that were already connected. So, when
browsing runtime page of USB, even if disables the preference, the changing of
that tabs added/removed reflects to the page. To avoid this, closes connections
that were connected to USB when the preference will be disabled.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Update usb devices when the debugger client of usb was closed. r?jdescottes

Depends on D9889

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Close connections that were accepted in ServerSocketListener. r=ochameau!,jdescottes!

Yet another approach. In the previous D9889 approach, both DebuggerSerever and
SocketServerListener retain the connections duplicately, it will be possible to
be difficult for the management. In this approach, only DebuggerSerever retains
the connections, then when ServerSocketListener was removed, removes the
connections as well that were linked the ServerSocketListener.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Use try/catch for _handle function in ServerSocketConnection. r=ochameau!,jdescottes!

At first, I wanted it is better to call DebuggerServer.destroy() when
`devtools.debugger.remote-enabled` will set to false. Likewise, call
DebuggerServer.init() in case of true. But, because DebuggerServer.init() is
called by various context such as RemoteDebugger, restoring is difficult after
destroying. In this patch, simply, we make avoiding to call
DebuggerServer.closeAllListener() from inside of ServerSocketConnection.

Depends on D10864

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Use SocketListener directly. r=ochameau!,jdescottes!

Depends on D10865

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Rename _addListener/_removeListener of DebuggerServer to addSocketListener/removeSocketListener. r=ochameau!,r=jdescottes!

Depends on D10867

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/908dc14f2736
Close connections that were accepted in ServerSocketListener. r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/2f968d0631f5
Use try/catch for _handle function in ServerSocketConnection. r=ochameau,jdescottes

Comment 8

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1497448: Rename closeAllListener to closeAllSocketListeners. r?ochameau,r?jdescottes

Depends on D10868

Comment 9

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/908dc14f2736
https://hg.mozilla.org/mozilla-central/rev/2f968d0631f5

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e8ae528176e
Use SocketListener directly. r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f1277f997312
Rename _addListener/_removeListener of DebuggerServer to addSocketListener/removeSocketListener. r=ochameau,jdescottes
https://hg.mozilla.org/integration/autoland/rev/f81b0f27c995
Rename closeAllListener to closeAllSocketListeners. r=ochameau,jdescottes

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/2e8ae528176e
https://hg.mozilla.org/mozilla-central/rev/f1277f997312
https://hg.mozilla.org/mozilla-central/rev/f81b0f27c995

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63eb34f9b171
Update usb devices when the debugger client of usb was closed. r=jdescottes

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/63eb34f9b171