Closed Bug 1497546 Opened 7 years ago Closed 7 years ago

Disable mirroring keyCode value and charCode value of keypress events due to bug 1497518

Categories

(Core :: DOM: Events, defect)

Product:
Core
Component:
DOM: Events
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 + fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: regression, site-compat)

Attachments

(1 file)

Bug 1497546 - Disable new behavior of keyCode and charCode of keypress event
46 bytes, text/x-phabricator-request
Details | Review
With reading the code roughly, it seems that Google Closure assumes that keyCode value of printable key's keypress event on Gecko is 0. So, we need to disable the new behavior until Closure fixes the new issue or we create blacklist to disable the website per domain.
The fix of bug 1479964 breaks some web apps using Google Closure including Google's apps. So, for Nightly testers, we should disable the new behavior until Google Closure fixes it or we can disable the new behavior per web apps.
No longer blocks: 1497518
Depends on: 1497518
Pushed by rgurzau@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/550aa5330baf Disable new behavior of keyCode and charCode of keypress event r=smaug a=Aryx
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox62: --- → unaffected
status-firefox63: --- → unaffected
status-firefox64: affected → fixed
status-firefox-esr60: --- → unaffected
tracking-firefox64: --- → +
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Keywords: site-compat
Blocks: 1497685
No longer blocks: 1497685
Severity: normal → critical
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: