1497552 - Remove support for 44100 Hz in dtmf_tone_generator

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

If I recall correctly, support for 44100 Hz was added to stop assertions in the unit tests, not for actual calls. We should double check that it is still required (maybe we could change unit tests instead?) and if so, upstream it.

Comment 1

[Dan Minor [:dminor]]

With the assertions here [1] it should not be possible to request a DTMF tone at 44100 Hz here [2] or here [3] which are the only two places that DtmfToneGenerator::Init is called. This code can be safely removed.

[1] https://searchfox.org/mozilla-central/rev/f997bd6bbfc4773e774fdb6cd010142370d186f9/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc#2047
[2] https://searchfox.org/mozilla-central/rev/f997bd6bbfc4773e774fdb6cd010142370d186f9/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc#1823
[3] https://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/modules/audio_coding/neteq/neteq_impl.cc#1921

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1497552 - Remove support for 44100 Hz in dtmf_tone_generator; r=padenot!

Assertions in NetEqImpl::SetSampleRateAndChannels prevent us from requesting
tones at 44100 Hz, so this code can be safely removed.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ea04ec01e99
Remove support for 44100 Hz in dtmf_tone_generator; r=padenot

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/8ea04ec01e99