Remove support for application capturing from our local copy of webrtc.org

RESOLVED FIXED in Firefox 68

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
2 months ago

People

(Reporter: dminor, Assigned: dminor)

Tracking

(Blocks 1 bug)

63 Branch
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(5 attachments)

Assignee

Description

9 months ago
With the changes for getDisplayMedia (Bug 1321221) we plan to stop supporting application capture. When that happens (or perhaps concurrently), we can remove our local modifications for application capture to webrtc.org.
Assignee

Comment 1

7 months ago
I discussed this with :jib and we are planning to keep this around as deprecated for some time after Bug 1321221 lands. We're not planning to fix any bugs in the mean time (e.g. Bug 1466742).
See Also: → 1466742
Assignee

Comment 3

2 months ago

That might be for beta67 actually, I don't see the values change if I switch between beta67 and release66.

Assignee

Comment 4

2 months ago

Testing on https://mozilla.github.io/webrtc-landing/gum_test.html, prior to the removal, clicking on 'Application' gives a list of screens and windows to share, that is it functions identically to clicking 'Screen' or 'Window'. After the removal, a "OverconstrainedError: Constraints could be not satisfied" error is displayed.

Given the limited number of hits for this in Telemetry and the fact that no one else implemented Application Sharing, I think this is ok. We could remove just the webrtc.org portions of the code and leave the dom/media/* portions in place so it continues to work just like Window sharing, but I don't think it makes sense to retain the extra code when it isn't really used.

Assignee

Comment 5

2 months ago

This removes all references to application capture except from MediaSourceEnum.
That was left in place so as to not change the enumerated values used
for WEBRTC_GET_USER_MEDIA_TYPE telemetry.

Assignee

Comment 6

2 months ago

Depends on D28089

Assignee

Comment 7

2 months ago

Depends on D28090

Assignee

Comment 8

2 months ago

Depends on D28091

Comment 10

2 months ago
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f8b8e009ac08
Remove application capture support; r=ng
https://hg.mozilla.org/integration/autoland/rev/a853ab3519b4
Update json files (part 1); r=ng
https://hg.mozilla.org/integration/autoland/rev/3d62109347a8
Update json files (part 2); r=ng
https://hg.mozilla.org/integration/autoland/rev/82f244c85df1
Update moz.build file; r=ng
https://hg.mozilla.org/integration/autoland/rev/d4662bda9981
Remove Application from mediaCaptureWindowState; r=jib
You need to log in before you can comment on or make changes to this bug.