Closed Bug 1497559 Opened 2 years ago Closed 2 years ago

Remove support for application capturing from our local copy of webrtc.org

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

63 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: dminor, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(5 files)

With the changes for getDisplayMedia (Bug 1321221) we plan to stop supporting application capture. When that happens (or perhaps concurrently), we can remove our local modifications for application capture to webrtc.org.
I discussed this with :jib and we are planning to keep this around as deprecated for some time after Bug 1321221 lands. We're not planning to fix any bugs in the mean time (e.g. Bug 1466742).
See Also: → 1466742

That might be for beta67 actually, I don't see the values change if I switch between beta67 and release66.

Testing on https://mozilla.github.io/webrtc-landing/gum_test.html, prior to the removal, clicking on 'Application' gives a list of screens and windows to share, that is it functions identically to clicking 'Screen' or 'Window'. After the removal, a "OverconstrainedError: Constraints could be not satisfied" error is displayed.

Given the limited number of hits for this in Telemetry and the fact that no one else implemented Application Sharing, I think this is ok. We could remove just the webrtc.org portions of the code and leave the dom/media/* portions in place so it continues to work just like Window sharing, but I don't think it makes sense to retain the extra code when it isn't really used.

This removes all references to application capture except from MediaSourceEnum.
That was left in place so as to not change the enumerated values used
for WEBRTC_GET_USER_MEDIA_TYPE telemetry.

Depends on D28089

Depends on D28090

Depends on D28091

No longer depends on: 1646904
You need to log in before you can comment on or make changes to this bug.