1497559 - Remove support for application capturing from our local copy of webrtc.org

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

With the changes for getDisplayMedia (Bug 1321221) we plan to stop supporting application capture. When that happens (or perhaps concurrently), we can remove our local modifications for application capture to webrtc.org.

Comment 1

[Dan Minor [:dminor]]

I discussed this with :jib and we are planning to keep this around as deprecated for some time after Bug 1321221 lands. We're not planning to fix any bugs in the mean time (e.g. Bug 1466742).

Comment 2

[Dan Minor [:dminor]]

Looking at the latest Telemetry for WEBRTC_GET_USER_MEDIA_TYPE in Firefox 66 [1], we're seeing 20 samples out of 2.81 million samples for application sharing. I think we are safe to go ahead and remove this.

[1] https://telemetry.mozilla.org/new-pipeline/dist.html#!cumulative=0&end_date=2019-04-11&include_spill=0&keys=__none__!__none__!__none__&max_channel_version=beta%252F67&measure=WEBRTC_GET_USER_MEDIA_TYPE&min_channel_version=nightly%252F65&processType=*&product=Firefox&sanitize=1&sort_by_value=0&sort_keys=submissions&start_date=2019-03-18&table=0&trim=1&use_submission_date=0

Comment 3

[Dan Minor [:dminor]]

That might be for beta67 actually, I don't see the values change if I switch between beta67 and release66.

Comment 4

[Dan Minor [:dminor]]

Testing on https://mozilla.github.io/webrtc-landing/gum_test.html, prior to the removal, clicking on 'Application' gives a list of screens and windows to share, that is it functions identically to clicking 'Screen' or 'Window'. After the removal, a "OverconstrainedError: Constraints could be not satisfied" error is displayed.

Given the limited number of hits for this in Telemetry and the fact that no one else implemented Application Sharing, I think this is ok. We could remove just the webrtc.org portions of the code and leave the dom/media/* portions in place so it continues to work just like Window sharing, but I don't think it makes sense to retain the extra code when it isn't really used.

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1497559 - Remove application capture support; r=ng!

This removes all references to application capture except from MediaSourceEnum.
That was left in place so as to not change the enumerated values used
for WEBRTC_GET_USER_MEDIA_TYPE telemetry.

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1497559 - Update json files (part 1); r=ng!

Depends on D28089

Comment 7

[Dan Minor [:dminor]]

Attachment: Bug 1497559 - Update json files (part 2); r=ng!

Depends on D28090

Comment 8

[Dan Minor [:dminor]]

Attachment: Bug 1497559 - Update moz.build file; r=ng!

Depends on D28091

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1497559 - Remove Application from mediaCaptureWindowState; r=jib!

Depends on D28092

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8b8e009ac08
Remove application capture support; r=ng
https://hg.mozilla.org/integration/autoland/rev/a853ab3519b4
Update json files (part 1); r=ng
https://hg.mozilla.org/integration/autoland/rev/3d62109347a8
Update json files (part 2); r=ng
https://hg.mozilla.org/integration/autoland/rev/82f244c85df1
Update moz.build file; r=ng
https://hg.mozilla.org/integration/autoland/rev/d4662bda9981
Remove Application from mediaCaptureWindowState; r=jib

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/f8b8e009ac08
https://hg.mozilla.org/mozilla-central/rev/a853ab3519b4
https://hg.mozilla.org/mozilla-central/rev/3d62109347a8
https://hg.mozilla.org/mozilla-central/rev/82f244c85df1
https://hg.mozilla.org/mozilla-central/rev/d4662bda9981