1497606 - Remove disable_composition_ in screen_capturer_win_gdi

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, enhancement, P3)

Description

[Dan Minor [:dminor]]

We have a few changes to control composition being disabled:

https://searchfox.org/mozilla-central/search?q=disable_composition_&redirect=false

We should upstream those.

Comment 1

[Dan Minor [:dminor]]

It appears that disable_composition_ is always set to false [1] and so these changes can be removed.

[1] https://searchfox.org/mozilla-central/rev/3fdc51e66c9487b39220ad58dcee275fca070ccd/dom/media/systemservices/video_engine/desktop_capture_impl.cc#347

Comment 2

[Dan Minor [:dminor]]

Now that I look at this again, it appears we added disable_composition_ to store the value of the option. I don't see why we can't just use whether or not composition_func_ has a value to track whether we've disabled composition which is what upstream does.

Comment 3

[Dan Minor [:dminor]]

Attachment: Bug 1497606 - Remove disable_composition_ in screen_capturer_win_gdi; r=ng

This removes disable_composition_ and instead uses the value of
composition_func_ to determine whether or not composition is
disabled. This is what is done by upstream webrtc.org.

We call options.set_disable_effects(false) in desktop_capture_impl.cc.

Comment 4

[Dan Minor [:dminor]]

Try run here: https://treeherder.mozilla.org/#/jobs?repo=try&revision=721a9c6a159177195261357864833b6f41ee2088

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b3f5cca4be44
Remove disable_composition_ in screen_capturer_win_gdi; r=ng

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/b3f5cca4be44