1497702 - dismissal of addon-installed panel leaves badge on appMenu

Status: VERIFIED FIXED

(WebExtensions :: Frontend, enhancement, P1)

Description

[Shane Caraveo (:mixedpuppy)]

Bug 1491438 moved the post install panel to the appMenu and made it "modal".  However, the one way to dismiss it without clicking "ok" in the panel is to click the appMenu (hamburger menu button).  That closes the panel, opens the appMenu.  Click again, and you get a red square badge.

There is no way to retrieve the panel at this point, you just get a badge always until something else might override it.  If we wanted to insert a menu item into the appMenu, we could address this, but I see no reason to do that for this panel.  Instead, when dismissed that way, we'll just remove the notification.

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1497702 remove app-installed notification upon dismissal, r?Gijs

Comment 2

[Shane Caraveo (:mixedpuppy)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e9d66fbc34cd4c057398579170d18f61d254ea6c

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/462ef74f8ce9
remove app-installed notification upon dismissal, r=Gijs

Comment 4

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/462ef74f8ce9

Comment 5

[Vlad Jiman]

Verified using Firefox 64.0a1 running on Windows 10 x64 bit, the red badge is no longer showed upon opening/closing the app menu, also verified that the badge is not affected and only goes away in these two cases (Pressing the OK button or opening the app menu)