1497725 - Search & filter entries in the new "about:config" page

Status: RESOLVED FIXED

(Toolkit :: Preferences, enhancement, P1)

Description

[Matthias :Kammueller]

Support for regex and "normal" search for preferences.
Filtering after component and whether the pref is modified or at its default value.

Comment 1

[:Paolo Amadini]

In the first version, we only need to search for a name that includes the typed string, when ENTER and maybe a Search button is pressed.

I'll split regular expression and modified to their own bugs, and for component search I guess you mean bug 1501422.

Comment 2

[:Paolo Amadini]

(In reply to :Paolo Amadini from comment #1)
> I'll split regular expression and modified to their own bugs

Actually, after looking at the ABOUT_CONFIG_FEATURES_USAGE probe, I don't think we need to implement the regular expression search any time soon. It's been used on 33 page loads, versus more than 7,260 for regular search, in the last week on Nightly, and exactly 1 time on Beta. Maybe favorites is something that might cover the only rare use case I can see of it, of showing multiple preferences for easy access without using multiple pinned tabs.

Sort by modified status is also similarly rare on Nightly, but stays higher on Beta. This is already not part of our Minimum Viable Product, but is something we can consider adding next.

Comment 3

[Luke Schwalfenberg [:lschwalf]]

Should this search/filter be able to filter entries by both their name and value similar to the current implementation in about:config?

Comment 4

[:Paolo Amadini]

(In reply to Luke Schwalfenberg [:lschwalf] from comment #3)
> Should this search/filter be able to filter entries by both their name and
> value similar to the current implementation in about:config?

Searching just the name seems fine to me. At the moment, the findbar can be used as well to look for specific values.

Comment 5

[Matthias :Kammueller]

(In reply to Luke Schwalfenberg [:lschwalf] from comment #3)
> Should this search/filter be able to filter entries by both their name and
> value similar to the current implementation in about:config?

We've got Bug 1501658 for that ;)

Comment 6

[Luke Schwalfenberg [:lschwalf]]

(In reply to :Matthias Kammüller from comment #5)
> (In reply to Luke Schwalfenberg [:lschwalf] from comment #3)
> > Should this search/filter be able to filter entries by both their name and
> > value similar to the current implementation in about:config?
> 
> We've got Bug 1501658 for that ;)

Did not realize that. Thanks for pointing that out Matthias. I'll revise the scope of the patch that I submit for this bug accordingly.

Comment 7

[Luke Schwalfenberg [:lschwalf]]

Attachment: Bug 1497725 - Search & filter entries in the new "about:config" page r?paolo

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef55dde9b93
Add a search field to the new "about:config" page. r=paolo

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/4ef55dde9b93