1497789 - WR is enabled for non-WR testing on Windows

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Sotaro Ikeda [:sotaro]]

By Bug 1413558 Comment 6 seemed to be enabled for non-WR testing on Windows.

It seemed to be caused by Bug 1490742.

Comment 1

[Sotaro Ikeda [:sotaro]]

Example failure.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=b3158d143d833ec52c938e5235c1f86409fb764b&selectedJob=203951019

The log has "[GFX1-]: Failed to connect WebRenderBridgeChild" even when we do not expect to run WebRender.

Comment 2

[Sotaro Ikeda [:sotaro]]

:jrmuizel, can you comment to the bug?

Comment 3

[Kartikaya Gupta (email:[e-mail])]

This is interesting. I looked at the other webgl tasks on that push. Two of them (gl2c and gl2e4) have the WebRenderBridgeChild error in the log. Those are also the only two tasks that ran in the us-west-2 WorkerGroup in taskcluster. All of the webgl tasks have virtualization set to virtual-with-gpu [1] but it's possible that the machines in the us-west-2 AWS region that satisfy this criteria are either real hardware machines with nvidia GPUs, or are virtual machines simulating an nvidia GPU. The other regions presumably don't do this, so the qualified check fails.

That being said, I'm not sure why it would say "Failed to connect WebRenderBridgeChild" - if webrender was getting enabled via the qualified pref it should just work properly.

[1] https://searchfox.org/mozilla-central/rev/80ac71c1c54af788b32e851192dfd2de2ec18e18/taskcluster/ci/test/mochitest.yml#360,384,407,430

Comment 4

[Sotaro Ikeda [:sotaro]]

I added log of "WebRenderLayerManager::Initialize", the result was the following. Normally connectting WebRenderBridgeChild succeeded, but sometimes it failed somehow.

https://treeherder.mozilla.org/#/jobs?repo=try&selectedJob=204458701&revision=5daf716e4576a3f3d6e9ac20622a7e927dd9f64c

Comment 5

[Jeff Muizelaar [:jrmuizel]]

We should probably figure out what's going on here sooner rather than later.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Seems unrelated to AWS regions, I see the WebRenderLayerManager::Initialize showing up on europe regions too. More logging needed, I guess.

Comment 7

[Kartikaya Gupta (email:[e-mail])]

So what's happening is basically that anything that's running on "virtual-with-gpu" (and maybe "hardware") virtualization on windows is getting WR enabled, because the gpu and qualified pref combine to enable it.

I think the right thing to do here is to set the qualified pref back to false for CI testing, so that we control which tests get WR enabled strictly using the MOZ_WEBRENDER envvar. And that envvar is set for the QR test platforms.

Comment 8

[Kartikaya Gupta (email:[e-mail])]

https://treeherder.mozilla.org/#/jobs?repo=try&group_state=expanded&revision=a1003126711eef99f253a43ac280a618b8fb7ab7

Comment 9

[Kartikaya Gupta (email:[e-mail])]

Attachment: Bug 1497789 - Keep the qualified pref off for automated testing. r?jrmuizel

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0fc8ecfa271
Keep the qualified pref off for automated testing. r=sotaro

Comment 11

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a0fc8ecfa271