Upstream changes to jitter_buffer.cc

RESOLVED FIXED in Firefox 65

Status

()

P3
normal
RESOLVED FIXED
5 months ago
3 months ago

People

(Reporter: dminor, Assigned: dminor)

Tracking

(Blocks: 1 bug)

63 Branch
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
This bit:
 if (frame->Length() == 0) {
    // Normally only if MakeDecodable() on an incomplete frame threw it all away
    ReleaseFrame(frame);
    return NULL;
  }
(Assignee)

Comment 1

3 months ago
These modifications are made to code which we do not use and so
can be removed.
(Assignee)

Comment 2

3 months ago
This is in VCMJitterBuffer::ExtractAndSetDecode. The only place this is called outside of test code is in VCMReceiver::FrameForDecoding. The only place that is called outside of test code is in vcm::VideoReceiver::Decode which is only called outside of test code in VideoCodingModuleImpl::Decode, which is never called anywhere.

This is dead code and can be removed.
Assignee: nobody → dminor
Status: NEW → ASSIGNED
So you're saying that all of VideoReceiver::Decode() is dead code?  (Is all of VideoReceiver?)  How did you check it isn't used anywhere?  (Not saying this is wrong, just want to make sure)
Flags: needinfo?(dminor)

Comment 5

3 months ago
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2fb1dd0d8344
Remove local changes to jitter_buffer.cc; r=pehrsons

Comment 6

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2fb1dd0d8344
Status: ASSIGNED → RESOLVED
Last Resolved: 3 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.