149803 - cannot save file using latest trunk linux - dowloading a build is broken

Status: VERIFIED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Asa Dotzler [:asa]]

Saving a file on the latest linux trunk does not work. Build ID 060608

Steps to reproduce:
1. go to ftp.mozilla.org/pub/mozilla/nightly/latest-trunk/
2. click on a linux build to download.
3. select a location to save.

Results: no file saved.
Expected: file is downloaded.

I can save a page and when doing so I get the download manager. I never see the
download manager when trying to save a tar.gz file.  Save link target works but
just clicking on the link does not.

Comment 1

[Asa Dotzler [:asa]]

blake says check with alecf.

Comment 2

[Boris Zbarsky [:bzbarsky]]

My money is on the patch from bug 140136...

Comment 3

[Alec Flett]

oh sorry I didn't realize this was a smoketest blocker. I'm still waiting on my
build, but if someone could try backing out my fix to bug 140136, that would
probably be the best start. Anyone?

Comment 4

[Alec Flett]

Attachment: backout changes

or how about this - nobody respond to my first question and then I get fed up
and post a patch....?

Comment 5

[Alec Flett]

I have no idea if this works, but my build is almost done, and I can test it
then. to fix this, apply this in uriloader/exthandler/ and make libs from uriloader/

Comment 6

[Alec Flett]

Attachment: backout v1.01

better yet, I'll attach a patch that compiles.

Comment 7

[Alec Flett]

ok, my windows build is finished, and I can download both with and without this
patch. is this linux-only? if so, I really need help here - I spent the morning
upgrading my system to redhat 7.3, and am only now starting my linux build...

Comment 8

[Alec Flett]

wait a second! I wonder if I fixed this yesterday with bug 149230?

Comment 9

[Samir Gehani]

I can't reproduce this bug using the 2002060608 mozilla-i686-pc-linux-gnu.tar.gz
tarball build.  I can successfully save a tarball by clicking on a link and
subsequently clicking the `Save' button on the file picker that shows up.  I
think I followed Asa's steps to the letter.

Comment 10

[Alec Flett]

ok, that was it - I backed out only yesterday's fix, and saving files stopped
working. So this has been fixed, and is not a blocker for today's build!

I'm so glad people are actually confirming that these bugs exist in the current
build.

Comment 11

[Alec Flett]

f-f-f-f-f-fixed already.

Comment 12

[Samir Gehani]

The 2002060708 mozilla-i686-pc-linux-gnu.tar.gz tarball build also doesn't
manifest this problem for me.  But wait!  There's more: with today's build I see
the download manager whereas with the 2002060608 build I did not get the
download manager.  In both cases I confirmed that the downloaded file was valid
(untarred successfully).

Comment 13

[Alec Flett]

by the way, the trick to reproducing this is to click on a file that does NOT
have a default MIME type, as configured by your browser - for instance, on
windows you can click on the mac .bin installer..

Comment 14

[Pete Boyd]

changing OS to All as I'd seen this on Windows 2000 the last couple of days.
build 2002060704 fixes this (atleast for a mozilla.org .exe download test which
before was broken)

Comment 15

[sairuh (rarely reading bugmail)]

downloading (single-click or context-click-"save link target") has been working
fine with recent trunk builds, all platforms (linux rh7.2, win2k, mac 10.1.5).