1498165 - Implement multi-store for scalars

Status: RESOLVED FIXED

(Toolkit :: Telemetry, enhancement, P1)

Description

[Jan-Erik Rediger [:janerik]]

Scalars need to gain functionality to record into multiple stores.

Comment 1

[Chris H-C :chutten]

Attachment: bug 1498165 - Support multistore in ScalarBoolean

Comment 2

[Chris H-C :chutten]

Attachment: bug 1498165 - Plumb the Scalar Store name down to the storage layer.

MozReview-Commit-ID: 5T9TZ5AgKci

Comment 3

[Chris H-C :chutten]

Attachment: bug 1498165 - Expose ScalarInfo store numbers and indices

Depends on D12127

Comment 4

[Chris H-C :chutten]

Attachment: bug 1498165 - Add common multistore behaviour to ScalarBase

ScalarBase needs to transform from store names to indices and provide
storage and logic for which stores have values.

Depends on D12128

Comment 5

[Chris H-C :chutten]

Attachment: bug 1498165 - Support multistore in ScalarUnsigned

This one's a little trickier than the others because it has an implicit
default value of 0 for initial calls to AddValue and SetMaximum.

Depends on D12129

Comment 6

[Chris H-C :chutten]

Attachment: bug 1498165 - Plumb 'we wish to clear this' down to the storage layer

Depends on D12130

Comment 7

[Chris H-C :chutten]

Attachment: bug 1498165 - Support multistore in ScalarString

Depends on D12131

Comment 8

[Chris H-C :chutten]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a8241dd27ae6306f53df0d9b00721eb55ed77de2

Comment 9

[Chris H-C :chutten]

Whoops, missed a name change in the last one. Here's one with the name change fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b13958e02ab5863b5be5dc745c5fe896bc0e4796

Comment 10

[Chris H-C :chutten]

Annnd implicit conversion ctors ruined the last one. This one has green builds at least: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3afd48140343f157d352beb58cf6e4331c6f0752

Revisions are ready for your review when you want them, Jan-Erik.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3a1d87f178a
Plumb the Scalar Store name down to the storage layer. r=janerik
https://hg.mozilla.org/integration/autoland/rev/a6fd82999912
Expose ScalarInfo store numbers and indices r=janerik
https://hg.mozilla.org/integration/autoland/rev/242721140915
Add common multistore behaviour to ScalarBase r=janerik
https://hg.mozilla.org/integration/autoland/rev/97f08187a60b
Support multistore in ScalarUnsigned r=janerik
https://hg.mozilla.org/integration/autoland/rev/f6d547bb7dc3
Plumb 'we wish to clear this' down to the storage layer r=janerik
https://hg.mozilla.org/integration/autoland/rev/898a5386162e
Support multistore in ScalarString r=janerik

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on TelemetryScalar.cpp

Push link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&selectedJob=212962051&revision=898a5386162e95a8dcf7919d080df0307008fbb8
Backout link: https://hg.mozilla.org/integration/autoland/rev/507698ccab9b52f5cb4a1246a5c19f26d20f82d8
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=212962081&repo=autoland&lineNumber=31305

Comment 13

[Chris H-C :chutten]

Ack! Lando missed one of the patches!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/893aaa718e6f
Plumb the Scalar Store name down to the storage layer. r=janerik
https://hg.mozilla.org/integration/autoland/rev/8db1d9f8025c
Expose ScalarInfo store numbers and indices r=janerik
https://hg.mozilla.org/integration/autoland/rev/63a07c0d07ae
Add common multistore behaviour to ScalarBase r=janerik
https://hg.mozilla.org/integration/autoland/rev/14622853d38c
Support multistore in ScalarUnsigned r=janerik
https://hg.mozilla.org/integration/autoland/rev/c6176b21937b
Plumb 'we wish to clear this' down to the storage layer r=janerik
https://hg.mozilla.org/integration/autoland/rev/eeefb2421819
Support multistore in ScalarString r=janerik
https://hg.mozilla.org/integration/autoland/rev/91c9a4e6d7a8
Support multistore in ScalarBoolean r=janerik

Comment 15

[Chris H-C :chutten]

There. Seven this time.

Comment 16

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/893aaa718e6f
https://hg.mozilla.org/mozilla-central/rev/8db1d9f8025c
https://hg.mozilla.org/mozilla-central/rev/63a07c0d07ae
https://hg.mozilla.org/mozilla-central/rev/14622853d38c
https://hg.mozilla.org/mozilla-central/rev/c6176b21937b
https://hg.mozilla.org/mozilla-central/rev/eeefb2421819
https://hg.mozilla.org/mozilla-central/rev/91c9a4e6d7a8