Implement multi-store for scalars

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P1
normal
RESOLVED FIXED
9 months ago
8 months ago

People

(Reporter: janerik, Assigned: chutten)

Tracking

unspecified
mozilla65
Points:
3
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(7 attachments)

Scalars need to gain functionality to record into multiple stores.
Blocks: 1498172
Priority: -- → P3
Assignee: nobody → chutten
Blocks: 1505060
Status: NEW → ASSIGNED
Points: --- → 3
Priority: P3 → P1
Attachment #9025671 - Attachment is obsolete: true
MozReview-Commit-ID: 5T9TZ5AgKci
Depends on D12127
ScalarBase needs to transform from store names to indices and provide
storage and logic for which stores have values.

Depends on D12128
This one's a little trickier than the others because it has an implicit
default value of 0 for initial calls to AddValue and SetMaximum.

Depends on D12129
Attachment #9025671 - Attachment is obsolete: false
Depends on D12131
Whoops, missed a name change in the last one. Here's one with the name change fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=b13958e02ab5863b5be5dc745c5fe896bc0e4796
Annnd implicit conversion ctors ruined the last one. This one has green builds at least: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3afd48140343f157d352beb58cf6e4331c6f0752

Revisions are ready for your review when you want them, Jan-Erik.
Attachment #9025674 - Attachment description: bug 1498165 - Expose ScalarInfo store names and indices → bug 1498165 - Expose ScalarInfo store numbers and indices
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f3a1d87f178a
Plumb the Scalar Store name down to the storage layer. r=janerik
https://hg.mozilla.org/integration/autoland/rev/a6fd82999912
Expose ScalarInfo store numbers and indices r=janerik
https://hg.mozilla.org/integration/autoland/rev/242721140915
Add common multistore behaviour to ScalarBase r=janerik
https://hg.mozilla.org/integration/autoland/rev/97f08187a60b
Support multistore in ScalarUnsigned r=janerik
https://hg.mozilla.org/integration/autoland/rev/f6d547bb7dc3
Plumb 'we wish to clear this' down to the storage layer r=janerik
https://hg.mozilla.org/integration/autoland/rev/898a5386162e
Support multistore in ScalarString r=janerik
Flags: needinfo?(chutten)
Ack! Lando missed one of the patches!
Flags: needinfo?(chutten)
Pushed by chutten@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/893aaa718e6f
Plumb the Scalar Store name down to the storage layer. r=janerik
https://hg.mozilla.org/integration/autoland/rev/8db1d9f8025c
Expose ScalarInfo store numbers and indices r=janerik
https://hg.mozilla.org/integration/autoland/rev/63a07c0d07ae
Add common multistore behaviour to ScalarBase r=janerik
https://hg.mozilla.org/integration/autoland/rev/14622853d38c
Support multistore in ScalarUnsigned r=janerik
https://hg.mozilla.org/integration/autoland/rev/c6176b21937b
Plumb 'we wish to clear this' down to the storage layer r=janerik
https://hg.mozilla.org/integration/autoland/rev/eeefb2421819
Support multistore in ScalarString r=janerik
https://hg.mozilla.org/integration/autoland/rev/91c9a4e6d7a8
Support multistore in ScalarBoolean r=janerik
There. Seven this time.
You need to log in before you can comment on or make changes to this bug.