Closed Bug 1498274 Opened 6 years ago Closed 6 years ago

Remove grouping from the download interstitial dialog and the dialog to set the desktop background

Categories

(Firefox :: General, enhancement, P1)

Product:
Firefox
Component:
General
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: Paolo, Assigned: Paolo)

References

Details

Attachments

(1 file)

Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins
46 bytes, text/x-phabricator-request
Details | Review 
The download interstitial dialog and the dialog to set the desktop background are two other cases where grouping is not really necessary.

For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure.
These are two other cases where grouping is not really necessary. For accessibility, the checkbox at the end of the download interstitial dialog does not need to be in the same group as the radio button, and the question text can more simply just label the radiogroup. The vbox is still necessary to hide the section, but is not related to accessibility or dialog structure.
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c11d8d96c24
Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ
https://hg.mozilla.org/mozilla-central/rev/4c11d8d96c24
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
Depends on: 1529363
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: