1529363 - Set As Desktop Background preview is horizontally stretched

Status: VERIFIED FIXED

(Firefox :: Shell Integration, defect, P1)

Description

[Ian Moody [:Kwan] (UTC+1)]

Regression window: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=54091f6d7ec7d753b14a7220c6d282090d4d9d48&tochange=9a4b8f268757c4ea57a7cc490a1585e7e5816811

Regressed by:
4c11d8d96c24 Paolo Amadini — Bug 1498274 - Remove grouping from the download interstitial dialog and the dialog to set the desktop background. r=bgrins,MarcoZ

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1529363 - Rewrite browser_420786.js test to use add_task and BTU.withNewTab. r=paolo

Currently the test fails since it throws "TypeError: content is null". This
hasn't been noticed since this test only runs when gsettings is absent and
presumably all the test machines have it.

Comment 2

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1529363 - Add GSettings testing to browser_420786.js. r=paolo

It seems like none of the Linux test runners lack GSettings, so effectively this
test hasn't actually been testing anything for a while.

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1529363 - Fix SetDesktopBackground preview. r=paolo

Bug 1498274 removed the enclosing groupbox, which also removed the XBL box that
bounded the image size. Add a vbox to do so.
Also add a test that checks the image's sizes match its natural sizes.

Comment 4

[Ian Moody [:Kwan] (UTC+1)]

[Tracking Requested - why for this release]:
User interface regression.

Comment 5

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1529363 - Add domWindowOpenedAndLoaded function to BrowserTestUtils. r=paolo

Used to wait for a (particular) window to open and its contents to load.

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Want to request uplift to beta? We still have a couple of weeks of beta builds left and this has new tests so I'm inclined to take the fix if you think it is safe.

Comment 7

[Ian Moody [:Kwan] (UTC+1)]

Green try (couple known intermittents, bug in TV where it's surprised it can't find a file marked skip-if = verify when running tests by path)
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d881eb9a1e226df5c6fce89e9771314af7e21408&selectedJob=232241966

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ae9e2afee56
Rewrite browser_420786.js test to use add_task and BTU.withNewTab. r=paolo
https://hg.mozilla.org/integration/autoland/rev/00f103fd2a42
Add GSettings testing to browser_420786.js. r=paolo
https://hg.mozilla.org/integration/autoland/rev/fdb89003ea13
Fix SetDesktopBackground preview. r=paolo

Comment 9

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/2ae9e2afee56
https://hg.mozilla.org/mozilla-central/rev/00f103fd2a42
https://hg.mozilla.org/mozilla-central/rev/fdb89003ea13

Comment 10

[Ian Moody [:Kwan] (UTC+1)]

While this would have been very safe (only restoring some of the DOM structure previously removed) it seems to be too late now (and also isn't that severe a regression).

Comment 11

[Rares Doghi, Desktop QA]

Hi, I tested this issue on Windows 10, Ubuntu and Mac OsX using the latest Firefox Beta 67.0b3, this issue no longer occurs, I will Mark it Verified as Fixed.