Closed Bug 1498434 Opened 6 years ago Closed 6 years ago

add new telemetry probe to know the delay caused by e10s back pressure

Categories

(Core :: Networking: HTTP, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: CuveeHsu, Assigned: CuveeHsu)

References

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

If the e10s back pressure triggers a suspension, the sequence will be
(a) httpChannelParent sends more than 1/4 MB data to child which is unread
(b) let nsHttpChannel suspend the socket
(c) httpChannelChild sends enough ack to let parent resume the socket
(d) nsHttpParent get the data again and send to child

we want to measure the time difference between (c) and (d)

Jason, I'd like to confirm it is what you want.
Flags: needinfo?(jduell.mcbugs)
s/ 1/4 / 1
Flags: needinfo?(jduell.mcbugs)
Assignee: nobody → juhsu
A few things in a drive-by:

1) Please remember to gain Data Collection Review for all new or changed data collections in Firefox: https://wiki.mozilla.org/Firefox/Data_Collection
2) You might find Telemetry::AccumulateTimeDelta will suit your needs more closely than the general Telemetry::Accumulate
3) Convention is for Telemetry metrics that record timings in milliseconds to end in _MS
Thanks for Valentin's review and :chutten's comments.
Attached file Request_1498434.txt
data-r?
Attachment #9018415 - Flags: review?(francois)
Comment on attachment 9018415 [details]
Request_1498434.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Not yet, see my comments in the other patch.

Please r? me again once that is fixed.
Attachment #9018415 - Flags: review?(francois) → review-
Comment on attachment 9018415 [details]
Request_1498434.txt

Sorry, I updated the wrong bug.
Attachment #9018415 - Flags: review- → review?(francois)
Comment on attachment 9018415 [details]
Request_1498434.txt

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json

2) Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, telemetry setting.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?**

Not permanent.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?  **

Category 1.

5) Is the data collection request for default-on or default-off?

Default ON, only in pre-release channels.

6) Does the instrumentation include the addition of **any *new* identifiers** (whether anonymous or otherwise; e.g., username, random IDs, etc.  See the appendix for more details)?

No.

7) Is the data collection covered by the existing Firefox privacy notice? 

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, telemetry alerts are sufficient.
Attachment #9018415 - Flags: review?(francois) → review+
please check-in this after Bug 1487559 to avoid possible conflict
Keywords: checkin-needed
Pushed by ncsoregi@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f2ce0b583163
add new telemetry probe to know the delay caused by e10s back pressure r=valentin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/f2ce0b583163
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.