1498450 - Avoid the footgun from @depends-function comparison

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

As seen in https://phabricator.services.mozilla.com/D7713?id=21357#inline-30414

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1498450 - Avoid the footgun from @depends-function comparison

While we do have some uses of @depends-function comparison in some
templaces, related to host/target, we ought to be using `is` comparisons
rather than `==` anyways, so we switch those, and prevent other kinds of
comparisons being used at all.

This unveils the one noted in
https://phabricator.services.mozilla.com/D7713?id=21357#inline-30414
(and surprisingly only that one), that we remove entirely since it was
doing nothing in practice. Bug 1492305 will have to add it back in a
proper form.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a232864e1002
Avoid the footgun from @depends-function comparison r=froydnj

Comment 3

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a232864e1002