Closed Bug 1498450 Opened Last year Closed Last year

Avoid the footgun from @depends-function comparison

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox64 fixed)

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

Attachments

(1 file)

While we do have some uses of @depends-function comparison in some
templaces, related to host/target, we ought to be using `is` comparisons
rather than `==` anyways, so we switch those, and prevent other kinds of
comparisons being used at all.

This unveils the one noted in
https://phabricator.services.mozilla.com/D7713?id=21357#inline-30414
(and surprisingly only that one), that we remove entirely since it was
doing nothing in practice. Bug 1492305 will have to add it back in a
proper form.
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/a232864e1002
Avoid the footgun from @depends-function comparison r=froydnj
https://hg.mozilla.org/mozilla-central/rev/a232864e1002
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.