1498550 - Perma win Bmsvc build/build/src/gfx/vr/service/OculusSession.cpp (189): error C2220: warning treated as error - no 'object' file generated

Status: RESOLVED FIXED

(Core :: WebVR, defect)

Description

[Eliza Balazs [:ebalazs_]]

This started on m-c:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&resultStatus=testfailed,busted,exception,usercancel,runnable&revision=7a0840d602524d3b4552a867092267bb3fd5e79e&searchStr=Bmsvc&selectedJob=205029326

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=205029326&repo=mozilla-central&lineNumber=19022

mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/2d'
10:45:30     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/2d'
10:45:30     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/2d'
10:45:30     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/2d'
10:45:30     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/2d'
10:45:33     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/vr/service'
10:45:33     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.8.4/VC/bin/Hostx64/x86/cl.exe -FoOculusSession.obj -c  -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/gfx/vr/service -Iz:/build/build/src/obj-firefox/gfx/vr/service -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/dom/base -Iz:/build/build/src/gfx/layers/d3d11 -Iz:/build/build/src/gfx/thebes -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX -wd4359    -Fdgenerated.pdb -FS  z:/build/build/src/gfx/vr/service/OculusSession.cpp
10:45:33     INFO -  OculusSession.cpp
10:45:33     INFO -  z:/build/build/src/gfx/vr/service/OculusSession.cpp(189): error C2220: warning treated as error - no 'object' file generated
10:45:33     INFO -  z:/build/build/src/gfx/vr/service/OculusSession.cpp(189): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
10:45:33     INFO -  z:/build/build/src/gfx/vr/service/OculusSession.cpp(192): warning C4334: '<<': result of 32-bit shift implicitly converted to 64 bits (was 64-bit shift intended?)
10:45:33     INFO -  z:/build/build/src/config/rules.mk:1118: recipe for target 'OculusSession.obj' failed
10:45:33     INFO -  mozmake.EXE[4]: *** [OculusSession.obj] Error 2
10:45:33     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/vr/service'
10:45:33     INFO -  mozmake.EXE[4]: *** Waiting for unfinished jobs....
10:45:33     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/webrender_bindings'
10:45:33     INFO -  mkdir -p '.deps/'
10:45:33     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/webrender_bindings'
10:45:33     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/webrender_bindings'
10:45:33     INFO -  gfx/webrender_bindings
10:45:33     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/webrender_bindings'
10:45:33     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/webrender_bindings'
10:45:33     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/webrender_bindings'
10:45:34     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/layers'
10:45:34     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.8.4/VC/bin/Hostx64/x86/cl.exe -FoWebRenderTextureHost.obj -c  -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DD3D_DEBUG_INFO -DMOZ_ENABLE_D3D10_LAYER -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/gfx/layers -Iz:/build/build/src/obj-firefox/gfx/layers -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/docshell/base -Iz:/build/build/src/layout/base -Iz:/build/build/src/layout/generic -Iz:/build/build/src/media/libyuv/libyuv/include -Iz:/build/build/src/gfx/skia -Iz:/build/build/src/gfx/skia/skia/include/config -Iz:/build/build/src/gfx/skia/skia/include/core -Iz:/build/build/src/gfx/skia/skia/include/gpu -Iz:/build/build/src/gfx/skia/skia/include/utils -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX -Iz:/build/build/src/obj-firefox/dist/include/cairo    -Fdgenerated.pdb -FS  z:/build/build/src/gfx/layers/wr/WebRenderTextureHost.cpp
10:45:34     INFO -  WebRenderTextureHost.cpp
10:45:34     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/layers'
10:45:34     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/layers'
10:45:34     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/layers'
10:45:34     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/layers'
10:45:34     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/layers'
10:45:35     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/gfx/vr/service'
10:45:35     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.cl  z:/build/build/src/vs2017_15.8.4/VC/bin/Hostx64/x86/cl.exe -FoUnified_cpp_gfx_vr_service0.obj -c  -Iz:/build/build/src/obj-firefox/dist/stl_wrappers -DDEBUG=1 -DWIN32_LEAN_AND_MEAN -D_WIN32 -DWIN32 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DOS_WIN=1 -D_UNICODE -DCHROMIUM_BUILD -DU_STATIC_IMPLEMENTATION -DUNICODE -D_WINDOWS -D_SECURE_ATL -DCOMPILER_MSVC -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -Iz:/build/build/src/gfx/vr/service -Iz:/build/build/src/obj-firefox/gfx/vr/service -Iz:/build/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -Iz:/build/build/src/ipc/chromium/src -Iz:/build/build/src/ipc/glue -Iz:/build/build/src/dom/base -Iz:/build/build/src/gfx/layers/d3d11 -Iz:/build/build/src/gfx/thebes -Iz:/build/build/src/obj-firefox/dist/include -Iz:/build/build/src/obj-firefox/dist/include/nspr -Iz:/build/build/src/obj-firefox/dist/include/nss -MD -FI z:/build/build/src/obj-firefox/mozilla-config.h -DMOZILLA_CLIENT -utf-8 -TP -nologo -w15038 -wd5026 -wd5027 -Zc:sizedDealloc- -wd4091 -wd4577 -D_HAS_EXCEPTIONS=0 -W3 -Gy -Zc:inline -arch:SSE2 -Gw -wd4251 -wd4244 -wd4267 -wd4800 -wd4595 -wd4065 -we4553 -D_SILENCE_TR1_NAMESPACE_DEPRECATION_WARNING -GR- -Zi -O1 -Oi -Oy- -WX -wd4359    -Fdgenerated.pdb -FS  z:/build/build/src/obj-firefox/gfx/vr/service/Unified_cpp_gfx_vr_service0.cpp
10:45:35     INFO -  Unified_cpp_gfx_vr_service0.cpp
10:45:35     INFO -  mozmake.EXE[4]: Leaving directory 'z:/build/build/src/obj-firefox/gfx/vr/service'
10:45:35     INFO -  z:/build/build/src/config/recurse.mk:74: recipe for target 'gfx/vr/service/target' failed
10:45:35     INFO -  mozmake.EXE[3]: *** [gfx/vr/service/target] Error 2
10:45:35     INFO -  mozmake.EXE[3]: *** Waiting for unfinished jobs....

kip: Hi, Can you have a look at this? This is related to https://bugzilla.mozilla.org/show_bug.cgi?id=1466700 Thank you!

Comment 1

[Cosmin Sabou [:CosminS]]

This escalated to tier1 bustage here: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success,testfailed,busted,exception&searchStr=windows,2012,x64,opt,build-win64-msvc%2Fopt,(bmsvc)&selectedJob=205129831&revision=32af88ce76dab548742417a74be9a13043540143

Comment 2

[:kip (Kearwood Gilbert)]

(In reply to Cosmin Sabou [:CosminS] from comment #1)
> This escalated to tier1 bustage here:
> https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=success,
> testfailed,busted,exception&searchStr=windows,2012,x64,opt,build-win64-
> msvc%2Fopt,
> (bmsvc)&selectedJob=205129831&revision=32af88ce76dab548742417a74be9a130435401
> 43

Please be aware that unless dependent bugs are backed out also, there will be many expected regressions including disabling of WebVR on Oculus devices and hanging during shutdown.  I will try to correct this warning and re-land it asap.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Sorry we missed you on IRC about this. Feel free to re-land the two backed out bugs whenever.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

FYI, the backouts were pushed to Autoland since that's where the MSVC builds are now at Tier 1. I can land your patches there for you if needed since it hasn't been merged around to inbound yet.

Comment 5

[:kip (Kearwood Gilbert)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> FYI, the backouts were pushed to Autoland since that's where the MSVC builds
> are now at Tier 1. I can land your patches there for you if needed since it
> hasn't been merged around to inbound yet.

Thanks Ryan, that would be very helpful.  In this case, the warning can be safely ignored.  IIUC, a simple cast from uint32 to uint64 should avoid the warning

Comment 6

[:kip (Kearwood Gilbert)]

(In reply to :kip (Kearwood Gilbert) from comment #5)
> (In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> > FYI, the backouts were pushed to Autoland since that's where the MSVC builds
> > are now at Tier 1. I can land your patches there for you if needed since it
> > hasn't been merged around to inbound yet.
> 
> Thanks Ryan, that would be very helpful.  In this case, the warning can be
> safely ignored.  IIUC, a simple cast from uint32 to uint64 should avoid the
> warning

I'll update the patch on the original bug, and NI you if that makes sense

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Yes, just NI in the bugs when they're ready to re-land.

Comment 8

[Intermittent Failures Robot]

1 failures in 2740 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-central: 1

Platform breakdown:
* windows2012-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1498550&startday=2018-10-08&endday=2018-10-14&tree=all