149859 - [XBLFC] Active Accessibility: support XBL-based HTML select

Status: RESOLVED WONTFIX

(Core :: Disability Access APIs, defect)

Description

[Kyle Yuan]

This bug is to get the Accessibility interface of new XBL-based form controls - 
select.

Comment 1

[Kyle Yuan]

Attachment: first part - for normal select (need work)

combobox is under developing...

Comment 2

[Kyle Yuan]

Attachment: full patch

brief comments of my patch:

accessible/src/html/nsHTMLSelectAccessible.cpp
1) (@@ -543,6 +543,16 @@) added support of STATE_INVISIBLE for
nsHTMLSelectOptionAccessible
2) (@@ -572,7 +582,7 @@) for support of size=1 <select> <option>

accessible/src/xul/nsXULFormControlAccessible.cpp
1) (@@ -242,6 +245,20 @@) for support of click action on dropmarks of size=1
<select>

accessible/src/xul/nsXULSelectAccessible.cpp
1) (@@ -58,15 +58,14 @@) corrected some comments
2) (other parts) added support of STATE_INVISIBLE for nsXULSelectListAccessible
and nsXULSelectOptionAccessible

accessible/src/xul/nsXULTreeAccessible.cpp
1) (@@ -60,6 +61,14 @@, @@ -372,6 +394,14 @@) added IsSelect() to distinguish
whether I'm a <select> or a <tree>
2) (@@ -105,7 +114,7 @@, @@ -402,7 +432,7 @@, @@ -453,10 +483,15 @@, @@ -467,14
+502,19 @@, @@ -536,8 +576,16 @@)
   distinguished the behaviors between <tree> and <select>
3) (@@ -328,7 +337,7 @@, @@ -342,6 +351,19 @@) added support of getting
nsITreeBoxObject from <select>
4) (@@ -440,7 +470,7 @@) It's a bug
5) (@@ -550,48 +598,7 @@) I did an adjusting job from local coordinates to
screen coordinates, but it doesn't work for <select>. Now I move this job into
<tree> widget. That's more simple.
   
layout/html/forms/resources/content/select.xml
1) added nsIAccessibleProvider interface to <select>

layout/xul/*.*
1) added one more argument to getCoordsForCellItem() to support of retuning a
screen coordinates rectangle of a treecell;
2) added a new function FindChild() into nsTreeUtils, because <treechildren> is
an anonymous node of <select>

xpfe/global/resources/content/bindings/*.*
1) enabled XPConnect from JS code
2) (popup.xml) call createXULSelectListAccessible if it's a <select>

Comment 3

[Kyle Yuan]

known issues:

It works not fully correctly with <optgroup>:
1) for size>1 <select>, an optgroup item should have two actions: 
expand/collapse and select
2) for size=1 <select>, it can't get all AccChildren of optgroup. (normal form 
control <select> accessible can't either)

I would delay this fix to another bug until we fixed the normal <optgroup> impl.