1498975 - Thunderbird Beta 63.0b1: In Update History, release notes link is broken

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Kiran]

Attachment: thunderbird-options-update-releasenotes.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

Steps to reproduce:

Go to Options -> Advanced -> Update -> Show Update History.
Click on Details, to view release details / notes


Actual results:

Get to see a 404 page with the message:
"The requested URL /en-US/thunderbird/63.0/releasenotes/ was not found on this server."


Expected results:

Should have opened this link: https://www.thunderbird.net/en-US/thunderbird/63.0beta/releasenotes/

Comment 1

[Wayne Mery (:wsmwk)]

Thanks for reporting this. I can confirm. However, I don't know if it is a regression / how long it has been broken.

Comment 2

[Andrei Hajdukewycz [:sancus]]

Someone is going to have to dig into how this list is building its URLs, as far as I can tell it still points at mozilla.org/thunderbird/{version}/releasenotes which is very old, and I can't find any pref that affects this.

Comment 3

[Richard Marti (:Paenglab)]

I can't say from where this URL is fetched but in Daily is this the Details URL: https://www.thunderbird.net/en-US/thunderbird/releases/ So correctly pointing to thunderbird.net.

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Richard Marti (:Paenglab) from comment #3)

I can't say from where this URL is fetched but in Daily is this the Details
URL: https://www.thunderbird.net/en-US/thunderbird/releases/ So correctly
pointing to thunderbird.net.

Perhaps jorg can point to someone

Comment 7

[Jorg K (CEST = GMT+2)]

Sorry, all of the version I have installed were installed manually and none shows a "Details" link. I tried TB 67 beta 1 and the "Release Notes" link works in the (advanced) update preferences. It shouldn't be too hard to work out where the pref comes from. Looks like the history comes from here:
https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/mozapps/update/content/history.xul#21
https://searchfox.org/mozilla-central/rev/d80f0a570736dce76a2eb184fb65517462089e8a/toolkit/mozapps/update/content/history.js#48

No idea who has some cycles to fix this. It might involve M-C changes. Maybe we can get Aceman interested.

Comment 8

[Andrei Hajdukewycz [:sancus]]

I think this is a server side thing in AUS/Balrog.

The detailsURL is clearly saved for each update in the history, and some searchfoxing and googling lead me to the documentation for Balrog release blobs: https://mozilla-balrog.readthedocs.io/en/latest/blobs.html#app-release

The schema clearly contains a detailsURL that looks like it contains the right information here.

@rjl: Rob, do you know if you can change this in Balrog and if so, does Balrog know what release channel a release is from or not? IE is it possible to change this to something like: https://live.thunderbird.net/thunderbird/releasenotes?version=67.0&channel=beta

That is how release notes links are defined in the client pref now.

Comment 9

[Rob Lemley [:rjl]]

Yes, the detailsURL in the Balrog blobs is what needs to change. It's probably generated somewhere in one of the balrog-submit tasks that happen when we push.

Comment 10

[Andrei Hajdukewycz [:sancus]]

Thanks. If possible the new URL should be:

https://live.thunderbird.net/thunderbird/releasenotes?locale=%LOCALE%&version=%VERSION%&channel=%CHANNEL%

Working example for 67 beta: https://live.thunderbird.net/thunderbird/releasenotes?locale=en-US&version=67.0&channel=beta

Comment 11

[Rob Lemley [:rjl]]

Attachment: detailsURL.patch

WIP: This might or not be the right direction to go with this.

Comment 12

[Jorg K (CEST = GMT+2)]

So what's the way forward? We already had a WNP and removed it again:
https://hg.mozilla.org/comm-central/rev/b682f20af95a

Comment 13

[Rob Lemley [:rjl]]

Attachment: detailsURL_v2.patch

I'd done the backout under the mistaken impression that Thunderbird didn't use the whats-new-config feature.
Putting it back, with the updated URL.

{version} gets rewritten to something like "67.0" or "68.0a1" (no "b" for betas)
{release-type} -> "release" || "beta" || "nightly"

The result gets sent to Balrog:
https://live.thunderbird.net/thunderbird/releasenotes?locale=%LOCALE%&version=68.0a1&channel=nightly

Comment 14

[Andrei Hajdukewycz [:sancus]]

Comment on attachment 9060618 [details] [diff] [review]
detailsURL_v2.patch

We don't have any release notes for Daily, so that just gets sent to the start page, which is fine.

https://live.thunderbird.net/thunderbird/releasenotes?locale=en-US&version=67.0&channel=beta
https://live.thunderbird.net/thunderbird/releasenotes?locale=en-US&version=60.6.1&channel=release both perform as expected.

This patch looks correct to me.

Comment 15

[Jorg K (CEST = GMT+2)]

Comment on attachment 9060618 [details] [diff] [review]
detailsURL_v2.patch

I suppose you want this in the beta? I can include it right now into TB 67 beta 2.

Comment 16

[Jorg K (CEST = GMT+2)]

TB 67 beta 2:
https://hg.mozilla.org/releases/comm-beta/rev/be92684912cce5982af2389b70bf03649b15a0be

Will land on trunk later today.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6164709e516d
Whats new config for Thunderbird releases. r=sancus

Comment 18

[Rob Lemley [:rjl]]

I pulled this from the release blob for Thunderbird-67.0beta2 built on 2019-04-25.

"updateLine": [
  {
    "fields": {
      "detailsURL": "https://live.thunderbird.net/thunderbird/releasenotes?locale=%LOCALE%&version=67.0&channel=beta",
      "type": "minor"
    },
    "for": {}
  }
]

Looks good to me.

Comment 19

[Andrei Hajdukewycz [:sancus]]

The correct link shows up and works on click for me in 67.0 Beta 2 after updating from Beta 1.

Note that old, previously recorded history links will not be fixed, only new ones going forward. That is fine, just recording that here in case the reporter or anyone else has a question about that.

Comment 20

[jmacauslan]

When is 68.0 due out? (Forgive my ignorance of what is presumably TB's standard schedule.)