Closed
Bug 1499135
Opened 3 years ago
Closed 3 years ago
ensure 'no browsing context' test in clear.py isn't relying on the previous page runs
Categories
(Testing :: geckodriver, defect, P2)
Tracking
(firefox64 wontfix)
RESOLVED
WONTFIX
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | wontfix |
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file, 1 obsolete file)
1.11 KB,
patch
|
ato
:
review+
|
Details | Diff | Splinter Review |
Is this too ugly for now?
Attachment #9017242 -
Flags: review?(ato)
Comment 1•3 years ago
|
||
Comment on attachment 9017242 [details] [diff] [review] clear_py_no_browsing_context.diff Review of attachment 9017242 [details] [diff] [review]: ----------------------------------------------------------------- r+wc This should do the trick for the time being. I’ve filed https://bugzilla.mozilla.org/show_bug.cgi?id=1499057 to fix the underlying problem, but feel free to apply this first: I can’t see it doing any harm. ::: testing/web-platform/tests/webdriver/tests/element_clear/clear.py @@ +47,5 @@ > assert value is None > > > def test_no_browsing_context(session, closed_window): > + element = Element("foo" . time.time(), session) Are you sure this works? I would expect "foo()".format(time.time()) to be more successful.
Attachment #9017242 -
Flags: review?(ato) → review+
Assignee | ||
Comment 2•3 years ago
|
||
oops. And lovely. that didn't show up as an error when running the test.
Assignee | ||
Comment 3•3 years ago
|
||
Just a simple concatenation then :)
Assignee: nobody → bugs
Attachment #9017242 -
Attachment is obsolete: true
Attachment #9017271 -
Flags: review?(ato)
Comment 4•3 years ago
|
||
(In reply to Andreas Tolfsen ❲:ato❳ from comment #1) > I would expect "foo()".format(time.time()) to be more successful. I assume you meant `"foo{}".format(..)` here.
Updated•3 years ago
|
Comment 6•3 years ago
|
||
(In reply to Henrik Skupin (:whimboo) from comment #4) > (In reply to Andreas Tolfsen ❲:ato❳ from comment #1) > > I would expect "foo()".format(time.time()) to be more successful. > > I assume you meant `"foo{}".format(..)` here. Yes, sorry. My Mac keyboard option key gets stuck all the time.
Comment 7•3 years ago
|
||
Comment on attachment 9017271 [details] [diff] [review] clear_py_no_browsing_context.diff Review of attachment 9017271 [details] [diff] [review]: ----------------------------------------------------------------- This works too, thanks 👍 I’ll clean this up later when I address the underlying problem with the Element abstraction.
Attachment #9017271 -
Flags: review?(ato) → review+
Pushed by opettay@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/97be1d70d0cd ensure 'no browsing context' test in clear.py isn't relying on the previous page runs, r=ato
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13541 for changes under testing/web-platform/tests
Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.
Comment 11•3 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/97be1d70d0cd
Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Upstream PR merged
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13541 * Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/aNfcHWFHRLq-mn8AKgHzPg)
Comment 14•3 years ago
|
||
The patch got backed out because it causes test failures and is not needed anytime longer due to the full fix on bug 1499057: https://hg.mozilla.org/integration/mozilla-inbound/rev/a729ef8fab78
Resolution: FIXED → WONTFIX
Updated•3 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•