1499230 - Inline-size is too wide for empty <select> lists compared to other UAs

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, enhancement, P4)

Description

[Mats Palmgren (inactive)]

Attachment: Testcase

Edge and Chrome renders the testcase as expected: the <select>
content-box width appears to be zero in all cases.

I tend to think we should follow their example.
(Safari renders the first row a bit like us, but fails
completely in the 2nd row)

Note, you need the fix in bug 1499127 for the height
to be correct in the first row.

Comment 1

[Mats Palmgren (inactive)]

Attachment: Testcase

Comment 2

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e7f555a302d7711010631a66a8c1bf65ac98dcd6

Comment 3

[Mats Palmgren (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1902b661fcef4db8b4bb8040da61867c6a16d935
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cefb49e078e32702d47f73adb8883fcb6f7b7de0

Comment 4

[Mats Palmgren (inactive)]

Attachment: Make empty <select>s have zero content-box inline-size, like in other UAs

This patch also makes the reference for the test added in bug 1499127
render correctly, so we can enable that test now.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9018033 [details] [diff] [review]
Make empty <select>s have zero content-box inline-size, like in other UAs

Review of attachment 9018033 [details] [diff] [review]:
-----------------------------------------------------------------

So, this looks like it was introduced initially in:

  https://github.com/mozilla/gecko-dev/commit/e5db62821d3cc51cc603683095279e697f1982b4

which has no bug number or anything else

Then changed to two X in:

  https://github.com/mozilla/gecko-dev/commit/702462fbfe83be16edb7737a4c1f68bcebca5672

Which is bug 28593...

Then Boris actually changed it for the :empty rule we have today.

Anyway, this looks fine to me, thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a9b1d69e379a
Make empty <select>s have zero content-box inline-size, like in other UAs.  r=emilio

Comment 7

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a9b1d69e379a

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13758 for changes under testing/web-platform/tests

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13758
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/447771064?utm_source=github_status&utm_medium=notification)

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged