Closed Bug 1499230 Opened 3 years ago Closed 3 years ago
Inline-size is too wide for empty <select> lists compared to other UAs
Edge and Chrome renders the testcase as expected: the <select> content-box width appears to be zero in all cases. I tend to think we should follow their example. (Safari renders the first row a bit like us, but fails completely in the 2nd row) Note, you need the fix in bug 1499127 for the height to be correct in the first row.
Assignee: nobody → mats
This patch also makes the reference for the test added in bug 1499127 render correctly, so we can enable that test now.
Attachment #9018033 - Flags: review?(emilio)
Comment on attachment 9018033 [details] [diff] [review] Make empty <select>s have zero content-box inline-size, like in other UAs Review of attachment 9018033 [details] [diff] [review]: ----------------------------------------------------------------- So, this looks like it was introduced initially in: https://github.com/mozilla/gecko-dev/commit/e5db62821d3cc51cc603683095279e697f1982b4 which has no bug number or anything else Then changed to two X in: https://github.com/mozilla/gecko-dev/commit/702462fbfe83be16edb7737a4c1f68bcebca5672 Which is bug 28593... Then Boris actually changed it for the :empty rule we have today. Anyway, this looks fine to me, thanks!
Attachment #9018033 - Flags: review?(emilio) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/a9b1d69e379a Make empty <select>s have zero content-box inline-size, like in other UAs. r=emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13758 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks: Github PR https://github.com/web-platform-tests/wpt/pull/13758 * continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/447771064?utm_source=github_status&utm_medium=notification)
Upstream PR merged
You need to log in before you can comment on or make changes to this bug.