1499255 - Android: Crash when android SurfaceTexture is used(Video, WebGL)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Darkspirit]

(Markus Stange [:mstange] from bug 1498735 comment 0)
> [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=73edcb2dabe7c97460516ecaf7fb843c35235bab&selectedJob=205166206

Device: Moto G5

Nightly crashes if you play a video on any website.

Comment 1

[Sotaro Ikeda [:sotaro]]

I could reproduce the problem.

Comment 2

[Sotaro Ikeda [:sotaro]]

Before Bug 1502454 fix, I saw a crash at ClipManager::PushOverrideForASR(). Since Bug 1502454 fix, I saw the crash at TextureHost::CreateRenderTexture().

Comment 3

[Sotaro Ikeda [:sotaro]]

SurfaceTextureHost does not support CreateRenderTexture() yet. It caused a crash.

Comment 4

[Sotaro Ikeda [:sotaro]]

For debugging on android, I used Android Studio.
  https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_for_Android_build#Developing_Firefox_for_Android_in_Android_Studio

Comment 5

[Sotaro Ikeda [:sotaro]]

Attachment: wip patch

It addressed the crash, but rendering does not work yet.

Comment 6

[Sotaro Ikeda [:sotaro]]

During debugging, I saw that rust Log does not work as expected. Setting of the log seems not set as expected on android.

log::STATIC_MAX_LEVEL was set to WARN, but we expect it to INFO from https://dxr.mozilla.org/mozilla-central/source/toolkit/library/rust/shared/Cargo.toml#28

log::max_level() was always set to ERROR. GeckoLogger setting was overridden by someone.

Comment 7

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make SurfaceTextureHost to support WebRender

Comment 8

[Sotaro Ikeda [:sotaro]]

attachment 9024945 [details] [diff] [review] has the following problem. They are going to be addressed another new bugs.
- [1] mIgnoreTransform is not handled yet.
- [2] mContinuousUpdate is not handled yet.
- [3] Shader compilation failed when GL_OES_EGL_image_external_essl3 is not supported.

Comment 9

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make SurfaceTextureHost to support WebRender

Update nits.

Comment 10

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make SurfaceTextureHost to support WebRender

Comment 11

[Sotaro Ikeda [:sotaro]]

Attachment: patch - Make SurfaceTextureHost to support WebRender

Comment 12

[Nicolas Silva [:nical]]

Comment on attachment 9024962 [details] [diff] [review]
patch - Make SurfaceTextureHost to support WebRender

Review of attachment 9024962 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to have bugs on file for the missing pieces, in particular the implementation of RenderAndroidSurfaceTextureHostOGL::DeleteTextureHandle.

Comment 13

[Sotaro Ikeda [:sotaro]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=df8c1e3b0685b485fa032b8fb2a74c2cff862f12

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ebe325c20d
Make SurfaceTextureHost to support WebRender r=nical

Comment 15

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/b5ebe325c20d