Android: Crash when android SurfaceTexture is used(Video, WebGL)

RESOLVED FIXED in Firefox 65

Status

()

P2
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: darkspirit, Assigned: sotaro)

Tracking

(Depends on: 5 bugs, Blocks: 1 bug, {nightly-community})

64 Branch
mozilla65
Unspecified
Android
nightly-community
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

(URL)

Attachments

(1 attachment, 4 obsolete attachments)

(Reporter)

Description

5 months ago
(Markus Stange [:mstange] from bug 1498735 comment 0)
> [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=73edcb2dabe7c97460516ecaf7fb843c35235bab&selectedJob=205166206

Device: Moto G5

Nightly crashes if you play a video on any website.
Priority: -- → P2
(Assignee)

Updated

5 months ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

5 months ago
I could reproduce the problem.
(Assignee)

Comment 2

5 months ago
Before Bug 1502454 fix, I saw a crash at ClipManager::PushOverrideForASR(). Since Bug 1502454 fix, I saw the crash at TextureHost::CreateRenderTexture().
(Assignee)

Comment 3

5 months ago
SurfaceTextureHost does not support CreateRenderTexture() yet. It caused a crash.
Comment hidden (obsolete)
(Assignee)

Comment 6

5 months ago
During debugging, I saw that rust Log does not work as expected. Setting of the log seems not set as expected on android.

log::STATIC_MAX_LEVEL was set to WARN, but we expect it to INFO from https://dxr.mozilla.org/mozilla-central/source/toolkit/library/rust/shared/Cargo.toml#28

log::max_level() was always set to ERROR. GeckoLogger setting was overridden by someone.
(Assignee)

Updated

5 months ago
Depends on: 1505554
(Assignee)

Updated

5 months ago
Depends on: 1505559
(Assignee)

Updated

4 months ago
No longer depends on: 1505554
(Assignee)

Updated

4 months ago
No longer depends on: 1505559
Comment hidden (obsolete)
(Assignee)

Comment 8

4 months ago
attachment 9024945 [details] [diff] [review] has the following problem. They are going to be addressed another new bugs.
- [1] mIgnoreTransform is not handled yet.
- [2] mContinuousUpdate is not handled yet.
- [3] Shader compilation failed when GL_OES_EGL_image_external_essl3 is not supported.
(Assignee)

Updated

4 months ago
Attachment #9023184 - Attachment is obsolete: true
Comment hidden (obsolete)
(Assignee)

Updated

4 months ago
Depends on: 1507074
(Assignee)

Updated

4 months ago
Depends on: 1507076
(Assignee)

Updated

4 months ago
Depends on: 1507078
Comment hidden (obsolete)
(Assignee)

Updated

4 months ago
Attachment #9024962 - Flags: review?(nical.bugzilla)
(Assignee)

Updated

4 months ago
Summary: Android: Videos are crashing Nightly → Android: Crash when android SurfaceTexture is used(Video, WebGL)
Comment on attachment 9024962 [details] [diff] [review]
patch - Make SurfaceTextureHost to support WebRender

Review of attachment 9024962 [details] [diff] [review]:
-----------------------------------------------------------------

Please make sure to have bugs on file for the missing pieces, in particular the implementation of RenderAndroidSurfaceTextureHostOGL::DeleteTextureHandle.
Attachment #9024962 - Flags: review?(nical.bugzilla) → review+
(Assignee)

Updated

4 months ago
Depends on: 1507667
(Assignee)

Updated

4 months ago
Depends on: 1507669

Comment 14

4 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b5ebe325c20d
Make SurfaceTextureHost to support WebRender r=nical

Comment 15

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/b5ebe325c20d
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
(Assignee)

Updated

4 months ago
Depends on: 1510174
You need to log in before you can comment on or make changes to this bug.