1510174 - Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P2)

Description

[Sotaro Ikeda [:sotaro]]

By accident, I set wrong WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() in Bug 1499255, though during testing, I used correct value.

WrExternalImageBufferType should be WrExternalImageBufferType::TextureExternalHandle here.

Comment 1

[Sotaro Ikeda [:sotaro]]

It caused the following error during using SurfaceTexture.

> E webrender::device::gl: Failed to compile shader: brush_image
> E webrender::device::gl: ERROR: 0:190: 'sampler2DRect' : Reserved word. 
> E webrender::device::gl: ERROR: 0:190: 'sampler2DRect' : Syntax error:  syntax error
> E webrender::device::gl: INTERNAL ERROR: no main() function!
> E webrender::device::gl: ERROR: 2 compilation errors.  No code generated.
> E webrender::device::gl:

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: Bug 1510174 - Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() r?nical

By accident, WrExternalImageBufferType::TextureRectHandle was set in SurfaceTextureHost::CreateRenderTexture() instead of WrExternalImageBufferType::TextureExternalHandle in Bug 1499255.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e338cf25fc3
Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() r=kats

Comment 4

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/1e338cf25fc3