Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture()

RESOLVED FIXED in Firefox 65

Status

()

P2
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

(Blocks: 1 bug)

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 months ago
By accident, I set wrong WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() in Bug 1499255, though during testing, I used correct value.

WrExternalImageBufferType should be WrExternalImageBufferType::TextureExternalHandle here.
(Assignee)

Updated

4 months ago
Assignee: nobody → sotaro.ikeda.g
Summary: Fix Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() → Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture()
(Assignee)

Updated

4 months ago
Blocks: 1499255
(Assignee)

Updated

4 months ago
Blocks: 1485449
(Assignee)

Comment 1

4 months ago
It caused the following error during using SurfaceTexture.

> E webrender::device::gl: Failed to compile shader: brush_image
> E webrender::device::gl: ERROR: 0:190: 'sampler2DRect' : Reserved word. 
> E webrender::device::gl: ERROR: 0:190: 'sampler2DRect' : Syntax error:  syntax error
> E webrender::device::gl: INTERNAL ERROR: no main() function!
> E webrender::device::gl: ERROR: 2 compilation errors.  No code generated.
> E webrender::device::gl:
(Assignee)

Comment 2

4 months ago
By accident, WrExternalImageBufferType::TextureRectHandle was set in SurfaceTextureHost::CreateRenderTexture() instead of WrExternalImageBufferType::TextureExternalHandle in Bug 1499255.
Attachment #9027838 - Attachment description: Bug 1510174 - Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() → Bug 1510174 - Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() r?nical
(Assignee)

Updated

4 months ago
Blocks: 1504667
Priority: -- → P2

Comment 3

4 months ago
Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1e338cf25fc3
Fix WrExternalImageBufferType in SurfaceTextureHost::CreateRenderTexture() r=kats

Comment 4

4 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1e338cf25fc3
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.