1499440 - mark-as-started survival depending on Ship-itv2 roll-out to release/esr60

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Rok Garbas [:garbas]]

mark-as-shipped task failed

https://tools.taskcluster.net/groups/GjMZ3aWVT6qaaVRs3WZ8ug/tasks/F0RkO83ATmmdjCAsIEVUQg/runs/0/logs/public%2Flogs%2Flive_backing.log

since it didn't find a "devedition 64.0b1" release in shipit v1

tomprince created the release manually and garbas reran the task.

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Until we find a better way to make this for beta only, we need to re-land https://hg.mozilla.org/releases/mozilla-beta/rev/950b4168885978e03fba79c983a007ade5e50ae9 from bug 1475101 as the patches were initially depoyed for mozilla-beta only and got overwritten by central merge.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Before I forget, more things need to happen here:
* mark-as-started should be set for started in B1 Devedition 64.0b1
* need to hack mozilla-release as well to prevent scheduling that task in RC or remove the code altogether

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #1)
> Until we find a better way to make this for beta only, we need to re-land
> https://hg.mozilla.org/releases/mozilla-beta/rev/
> 950b4168885978e03fba79c983a007ade5e50ae9 from bug 1475101 as the patches
> were initially depoyed for mozilla-beta only and got overwritten by central
> merge.

Aki landed this on inbound + beta and RelMan agreed to wait until CI is green so we should be good for this b2 in 64.
* https://hg.mozilla.org/integration/mozilla-inbound/rev/e87d7028568e721e8d297ce62f9622e74d29bb37
* https://hg.mozilla.org/releases/mozilla-beta/rev/c82c77ea5e649fffe8dbadc7ecec3247186d4e5d

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [in-tree] release/esr configs to enable proper mark-as-started

This is to land on central + beta, ready for 64 release cycle in 6 weeks.

Comment 5

[Aki Sasaki (not active)]

Comment on attachment 9018346 [details] [diff] [review]
[in-tree] release/esr configs to enable proper mark-as-started

Thanks!

Comment 6

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: [in-tree] disable mark-as-started on all branches except beta until further notice

To be landed on mozilla-release and checked again before 64 release train.

Comment 7

[Aki Sasaki (not active)]

Comment on attachment 9018353 [details] [diff] [review]
[in-tree] disable mark-as-started on all branches except beta until further notice

I think this only needs to land on m-r.

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9018353 [details] [diff] [review]
[in-tree] disable mark-as-started on all branches except beta until further notice

https://hg.mozilla.org/releases/mozilla-release/rev/abafc901dbcc5b288134a89370e206bb30ef4bd7

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab27299789d3
add esr60/release configs for mark-as-started task.r=aki a=release

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 9018346 [details] [diff] [review]
[in-tree] release/esr configs to enable proper mark-as-started

https://hg.mozilla.org/integration/mozilla-inbound/rev/ab27299789d3c74d58140d9d6651bc1102e439ed
https://hg.mozilla.org/releases/mozilla-beta/rev/cfe0a7911244f6704cf5f3edcdf287d9c73fcaed

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

Status update:
* On mozilla-release, mark-as-release should be now disabled.
* On mozilla-central and beta there's configs to correct the scopes/workerType for esr60/release mark-as-started.

Rememberings:
We need to double-check before next mergeday the status of its full rollout to other branches.

If Ship-it v2 is ready before we merge 64 to release:
* we need to remember to uplift to esr60 this[1] patch after beta -> release was succesful and esr60 bumped
* we need to make sure the mark-as-started tasks are scheduled (the opposite of https://hg.mozilla.org/releases/mozilla-release/rev/abafc901dbcc5b288134a89370e206bb30ef4bd7)

If Ship-it v2 is *NOT* ready before we merge 64 to release:
* make sure we still filter release-mark-as-started tasks out (so https://hg.mozilla.org/releases/mozilla-release/rev/abafc901dbcc5b288134a89370e206bb30ef4bd7 stays on mozilla-release)

[1]: https://hg.mozilla.org/releases/mozilla-beta/rev/cfe0a7911244f6704cf5f3edcdf287d9c73fcaed

Comment 12

[Mihai Tabara [:mtabara]⌚️GMT]

I've added a pre-req in releasewarrior[1] as well to remember to do this on the 3rd of December

[1]: https://github.com/mozilla-releng/releasewarrior-data/blob/master/upcoming/devedition/devedition-devedition-
65.0b1.md#preflight-tasks-pre-go-to-build

Comment 13

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab27299789d3

Comment 14

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Mihai Tabara [:mtabara]⌚️GMT from comment #11)
> Status update:
> * On mozilla-release, mark-as-release should be now disabled.
> * On mozilla-central and beta there's configs to correct the
> scopes/workerType for esr60/release mark-as-started.
> 
> Rememberings:
> We need to double-check before next mergeday the status of its full rollout
> to other branches.
> 
> If Ship-it v2 is ready before we merge 64 to release:
> * we need to remember to uplift to esr60 this[1] patch after beta -> release
> was succesful and esr60 bumped
> * we need to make sure the mark-as-started tasks are scheduled (the opposite
> of
> https://hg.mozilla.org/releases/mozilla-release/rev/
> abafc901dbcc5b288134a89370e206bb30ef4bd7)
> 
> If Ship-it v2 is *NOT* ready before we merge 64 to release:
> * make sure we still filter release-mark-as-started tasks out (so
> https://hg.mozilla.org/releases/mozilla-release/rev/
> abafc901dbcc5b288134a89370e206bb30ef4bd7 stays on mozilla-release)
> 
> [1]:
> https://hg.mozilla.org/releases/mozilla-beta/rev/
> cfe0a7911244f6704cf5f3edcdf287d9c73fcaed

And https://hg.mozilla.org/releases/mozilla-beta/rev/950b4168885978e03fba79c983a007ade5e50ae9 for esr60 most likely as we need to backport the entire logic since it's not there. Not just the patch from comment 11.

Comment 15

[Rail Aliiev [:rail]]

Let's assume it is fixed now