1499483 - Make the Layout view the default sidebar tab

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Currently, the computed view is the default sidebar tab in 3 pane mode. This is to make the layout view the default sidebar tab.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

DAMP https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=3c27c984546e0d76065bb7402e515ad031f80111&newProject=try&newRevision=e795f3913a6dda1ea56bb357a7c6300054ae71dd&originalSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&newSignature=f79b6a4f1f8f53326d3056f6c8008c0ff4de0a94&filter=inspector&framework=12

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1499483.patch

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 9017740 [details] [diff] [review]
1499483.patch

Review of attachment 9017740 [details] [diff] [review]:
-----------------------------------------------------------------

Code change looks good to me. But I don't remember the product discussion on this topic, so let me ping Victoria and Martin to provide some rationale behind this change for reference.

Comment 4

[Patrick Brosset <:pbro>]

Victoria, Martin, could you please take a look at comment 3?

Comment 5

[Victoria Wang [:victoria]]

Yes, this would be great!

For me it's because: we've increased the importance of Layout by only showing the box model diagram there, are making a potentially very high-use tool with Flexbox, it's the future of integral Design Tools which have better debugging info that overlaps with (and is better organized) than Computed, and it's unique to our tools. Anyone who needs Computed can easily find it.

I may be overly biased by the fact that in 10 years of debugging websites, I only ever used Rules, not Computed, so that's a little weird.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0658fbb91e05
Make the Layout view the default sidebar tab. r=pbro

Comment 7

[Daniel Varga [:dvarga]]

Backed out changeset 0658fbb91e05 (Bug 1499483) for devtools chrome failure at devtools/client/inspector/test/browser_inspector_sidebarstate.js on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=206229776&revision=0658fbb91e05b270f67252ec87e918d59d4aaf6d

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=206245623&repo=mozilla-inbound&lineNumber=4165
            https://treeherder.mozilla.org/logviewer.html#?job_id=206229776&repo=mozilla-inbound&lineNumber=19538

Backout link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=206229776&revision=0d9b7b7a5aa5d30412233ffbbabe24dd26df97d0

[task 2018-10-17T22:40:24.617Z] 22:40:24     INFO - Buffered messages finished
[task 2018-10-17T22:40:24.618Z] 22:40:24     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_sidebarstate.js | object is correct - Got layoutview, expected computedview
[task 2018-10-17T22:40:24.619Z] 22:40:24     INFO - Stack trace:
[task 2018-10-17T22:40:24.620Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:test_is:1295
[task 2018-10-17T22:40:24.621Z] 22:40:24     INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_sidebarstate.js:checkTelemetryResults:97
[task 2018-10-17T22:40:24.622Z] 22:40:24     INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_sidebarstate.js:null:79
[task 2018-10-17T22:40:24.623Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-10-17T22:40:24.624Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-10-17T22:40:24.625Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-10-17T22:40:24.626Z] 22:40:24     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-10-17T22:40:24.627Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | value is correct - 
[task 2018-10-17T22:40:24.630Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | timestamp is greater than 0 - 
[task 2018-10-17T22:40:24.631Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | time_open is greater than 0 - 
[task 2018-10-17T22:40:24.635Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | category is correct - 
[task 2018-10-17T22:40:24.637Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | method is correct - 
[task 2018-10-17T22:40:24.638Z] 22:40:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-17T22:40:24.639Z] 22:40:24     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_sidebarstate.js | object is correct - Got computedview, expected layoutview
[task 2018-10-17T22:40:24.640Z] 22:40:24     INFO - Stack trace:
[task 2018-10-17T22:40:24.642Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:test_is:1295
[task 2018-10-17T22:40:24.643Z] 22:40:24     INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_sidebarstate.js:checkTelemetryResults:97
[task 2018-10-17T22:40:24.644Z] 22:40:24     INFO - chrome://mochitests/content/browser/devtools/client/inspector/test/browser_inspector_sidebarstate.js:null:79
[task 2018-10-17T22:40:24.645Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
[task 2018-10-17T22:40:24.646Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
[task 2018-10-17T22:40:24.647Z] 22:40:24     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
[task 2018-10-17T22:40:24.649Z] 22:40:24     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
[task 2018-10-17T22:40:24.650Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | value is correct - 
[task 2018-10-17T22:40:24.651Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | timestamp is greater than 0 - 
[task 2018-10-17T22:40:24.653Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | time_open is greater than 0 - 
[task 2018-10-17T22:40:24.654Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | category is correct - 
[task 2018-10-17T22:40:24.655Z] 22:40:24     INFO - TEST-PASS | devtools/client/inspector/test/browser_inspector_sidebarstate.js | method is correct - 
[task 2018-10-17T22:40:24.656Z] 22:40:24     INFO - Not taking screenshot here: see the one that was previously logged
[task 2018-10-17T22:40:24.658Z] 22:40:24     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/test/browser_inspector_sidebarstate.js | object is correct - Got layoutview, expected ruleview

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dc2238f2ba7
Make the Layout view the default sidebar tab. r=pbro

Comment 9

[Andrei Ciure[:aciure]]

:gl Please take a look at this tier 2 failures caused by this push.

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&selectedJob=206296014&revision=1dc2238f2ba7cf0a41b7d8901aff2f60e9b7d74e&searchStr=tv

Comment 10

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/1dc2238f2ba7

Comment 11

[Martin Balfanz [:mbalfanz]]

I agree with Victoria (comment 5), so good to go from my point of view.