1500019 - Intermittent devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js | Last rule name is font-weight - Got border-collapse, expected font-weight

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: aciure [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=206301198&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/NzHSTXAMRoaCoWimRmGGTg/runs/0/artifacts/public/logs/live_backing.log

07:14:50     INFO - TEST-PASS | devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js | Last rule value is bold - 
07:14:50     INFO - Buffered messages finished
07:14:50     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js | Last rule name is font-weight - Got border-collapse, expected font-weight
07:14:50     INFO - Stack trace:
07:14:50     INFO - chrome://mochikit/content/browser-test.js:test_is:1295
07:14:50     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js:checkPropertyOnAllRules:41
07:14:50     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js:null:24
07:14:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
07:14:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
07:14:50     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
07:14:50     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
07:14:50     INFO - Not taking screenshot here: see the one that was previously logged
07:14:50     INFO - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js | Last rule value is bold - Got collapse, expected bold
07:14:50     INFO - Stack trace:
07:14:50     INFO - chrome://mochikit/content/browser-test.js:test_is:1295
07:14:50     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js:checkPropertyOnAllRules:42
07:14:50     INFO - chrome://mochitests/content/browser/devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js:null:24
07:14:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
07:14:50     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
07:14:50     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
07:14:50     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
07:14:50     INFO - Leaving test bound 
07:14:50     INFO - GECKO(5424) | console.log: "[DISPATCH] action type:" "UPDATE_OFFSET_PARENT"
07:14:50     INFO - GECKO(5424) | console.log: "[DISPATCH] action type:" "UPDATE_LAYOUT"
07:14:51     INFO - Removing tab.
07:14:51     INFO - Waiting for event: 'TabClose' on [object XULElement].
07:14:51     INFO - Got event: 'TabClose' on [object XULElement].
07:14:51     INFO - Tab removed and finished closing
07:14:51     INFO - GECKO(5424) | MEMORY STAT | vsize 1786MB | vsizeMaxContiguous 132583453MB | residentFast 321MB | heapAllocated 136MB
07:14:51     INFO - TEST-OK | devtools/client/inspector/rules/test/browser_rules_add-property-and-reselect.js | took 1897ms

Comment 1

[Intermittent Failures Robot]

43 failures in 494 pushes (0.087 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 8
* mozilla-central: 8
* mozilla-beta: 1
* autoland: 11
* mozilla-inbound: 15

Platform breakdown:
* windows10-64-ccov: 1
* linux32-nightly: 1
* osx-10-10: 7
* windows7-32: 8
* macosx64-devedition: 1
* linux64: 13
* windows10-64: 12

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-18&endday=2018-10-18&tree=all

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Regression from bug 1499483?

Comment 3

[Intermittent Failures Robot]

58 failures in 501 pushes (0.116 failures/push) were associated with this bug yesterday.

Repository breakdown:
* try: 8
* mozilla-beta: 7
* mozilla-central: 11
* autoland: 21
* mozilla-inbound: 11

Platform breakdown:
* linux64: 18
* linux32-nightly: 1
* windows7-32: 8
* linux64-devedition: 2
* macosx64-devedition: 1
* linux64-nightly: 2
* windows10-64-nightly: 2
* linux32: 1
* windows10-64-ccov: 2
* windows10-64: 9
* windows7-32-nightly: 1
* windows7-32-devedition: 2
* windows10-64-devedition: 1
* osx-10-10: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-19&endday=2018-10-19&tree=all

Comment 4

[Andrei Ciure[:aciure]]

Retriggered:

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=206837840&searchStr=d2850078aeb1db3e7b16f2e840f0a9c34bd0fa9f&tochange=3eb04f5363eb661fa2ae544a934a7ace85b65282&fromchange=2c633215c5148a0ea416237b749032e44e7708fb&group_state=expanded

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&selectedJob=206277229&searchStr=e9c23738a78276812daaf9712ba9f5be26c7517c&tochange=1dc2238f2ba7cf0a41b7d8901aff2f60e9b7d74e&fromchange=4f6373f7b21155fadc01fbb03d8a4d1f3f3a1f2e&group_state=expanded

Comment 5

[Intermittent Failures Robot]

32 failures in 123 pushes (0.26 failures/push) were associated with this bug yesterday.

Repository breakdown:
* autoland: 10
* mozilla-inbound: 9
* try: 8
* mozilla-central: 5

Platform breakdown:
* windows10-64-ccov: 1
* linux32-nightly: 1
* macosx64-nightly: 1
* osx-10-10: 8
* windows10-64: 5
* linux32: 2
* windows7-32: 6
* linux64: 8

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-20&endday=2018-10-20&tree=all

Comment 6

[Intermittent Failures Robot]

157 failures in 2759 pushes (0.057 failures/push) were associated with this bug in the last 7 days.

This is the #13 most frequent failure this week.

** This test has failed more than 150 times in the last 21 days. It should be disabled until it can be fixed. ** 

Repository breakdown:
* mozilla-inbound: 42
* autoland: 48
* mozilla-beta: 8
* mozilla-central: 30
* try: 29

Platform breakdown:
* osx-10-10: 26
* linux32-nightly: 4
* linux64: 42
* windows10-64-devedition: 1
* windows7-32: 26
* macosx64-nightly: 2
* linux64-nightly: 3
* windows10-64-nightly: 3
* windows10-64: 31
* windows7-32-devedition: 2
* windows7-32-nightly: 2
* linux64-devedition: 3
* linux32: 5
* macosx64-devedition: 2
* windows10-64-ccov: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-15&endday=2018-10-21&tree=all

Comment 7

[Patrick Brosset <:pbro>]

Here's what I managed to figure out so far:
- in setPropertyOnAllRules, the test iterates over all rules currently displayed
- somewhere in there, the layout-view initializes, and that somehow causes the array of rules to be reset
- so the for loop exits early before having iterated over all rules
- therefore when we go to checkPropertyOnAllRules that fails because not all rules have been edited as expected.

So we need to find out why loading the Layout view resets the number of rules in _elementStyle.
Also, a fix for this test could be to explicitly wait for the Layout view to be fully loaded before starting.

Comment 8

[Patrick Brosset <:pbro>]

I think I understand what is going on: the fact that the Layout panel is visible by default means that we now have the ReflowTracker started by default. And that causes the rule-view to refresh entirely after the first element-style rule has been updated. So the list of rules is reset.
So we need to make sure the first rule (element-style) is updated first, separately, and wait for the event that signals that the rule-view has been refreshed. And then proceed to update the other rules.

Comment 9

[Patrick Brosset <:pbro>]

Attachment: Bug 1500019 - Wait for the inline-style rule to be updated before proceeding; r?gl!

Comment 10

[Intermittent Failures Robot]

63 failures in 430 pushes (0.147 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 10
* mozilla-central: 13
* mozilla-beta: 8
* try: 7
* autoland: 25

Platform breakdown:
* linux64-nightly: 1
* windows10-64-devedition: 1
* linux64-devedition: 2
* windows7-32: 8
* macosx64-devedition: 2
* linux64: 15
* windows10-64-ccov: 2
* linux32-nightly: 3
* windows7-32-devedition: 1
* osx-10-10: 10
* linux32: 7
* windows10-64: 9
* linux64-ccov: 1
* windows7-32-nightly: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-22&endday=2018-10-22&tree=all

Comment 11

[Patrick Brosset <:pbro>]

Try push with my patch and with many retriggers seems to show this is successfully fixed: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2158166b9339be571bcfbf17db3a8ed4588cd669&group_state=expanded

Comment 12

[Intermittent Failures Robot]

55 failures in 607 pushes (0.091 failures/push) were associated with this bug yesterday.

Repository breakdown:
* autoland: 21
* mozilla-inbound: 16
* oak: 2
* mozilla-central: 10
* try: 6

Platform breakdown:
* windows7-32-devedition: 1
* windows10-64: 11
* linux64-ccov: 1
* osx-10-10: 14
* macosx64-nightly: 1
* windows10-64-nightly: 1
* linux64: 16
* linux32: 5
* windows7-32: 5

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-23&endday=2018-10-23&tree=all

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/506fe32bb763
Wait for the inline-style rule to be updated before proceeding; r=gl

Comment 14

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/506fe32bb763

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5c5acf59e04c

Comment 16

[Intermittent Failures Robot]

36 failures in 496 pushes (0.073 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-beta: 7
* try: 8
* autoland: 3
* mozilla-inbound: 11
* mozilla-central: 7

Platform breakdown:
* windows7-32: 5
* linux64: 9
* windows10-64: 3
* linux32-nightly: 2
* linux64-nightly: 2
* windows7-32-nightly: 1
* osx-10-10: 7
* windows10-64-devedition: 1
* windows10-64-nightly: 1
* windows10-64-ccov: 1
* linux64-devedition: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-24&endday=2018-10-24&tree=all

Comment 17

[Intermittent Failures Robot]

156 failures in 2584 pushes (0.06 failures/push) were associated with this bug in the last 7 days.

This is the #9 most frequent failure this week.

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. ** 

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. ** 

Repository breakdown:
* oak: 2
* mozilla-beta: 15
* mozilla-central: 30
* try: 23
* mozilla-inbound: 37
* autoland: 49

Platform breakdown:
* windows10-64-nightly: 2
* linux64-ccov: 2
* linux64-nightly: 3
* macosx64-nightly: 1
* windows10-64-ccov: 3
* windows7-32-devedition: 2
* linux32: 12
* osx-10-10: 33
* linux64-devedition: 6
* macosx64-devedition: 2
* windows10-64: 23
* linux64: 40
* windows10-64-devedition: 2
* windows7-32-nightly: 2
* linux32-nightly: 5
* windows7-32: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1500019&startday=2018-10-22&endday=2018-10-28&tree=all