Closed Bug 1499504 Opened 3 years ago Closed 3 years ago

Magnifying glass icon is positioned to the right of search input instead of left


(Toolkit :: Add-ons Manager, defect, P2)




Tracking Status
firefox-esr60 --- unaffected
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- verified


(Reporter: yoasif, Assigned: mstriemer)



(Keywords: nightly-community, regression)


(3 files, 1 obsolete file)

Steps to reproduce:

1. Navigate to about:addons
2. Look for input near "Find more extensions"

What happens:

The magnifying glass icon is positioned to the right of the search input. 

Expected result:

The magnifying glass icon should be positioned to the left of the input, like in about:preferences or in the search engine input available in the Firefox toolbar.
Blocks: 1489296
I'm guessing this is on Windows, on a Mac both about:addons and about:preferences are on the left.
Assignee: nobody → mstriemer
I'm on Debian Testing and have both.
Priority: -- → P2
I believe this bug's summary is wrong. The icon should be on the right because it acts as a submit button. As opposed to other search fields, this one doesn't automatically search while typing.

This rule is messing up the icons:
Blocks: 1488730
Keywords: regression
Dão, maybe it makes sense to use a rightward facing arrow on the right if the "takes you to a new place" affordance is important here, like exists on about:home. 

about:home also uses the search engine icon (and not a magnifying glass), but I think in about:addons at least, it makes sense to be consistent with other search inputs, unless we replace the magnifying glass with an favicon (which would solve another issue I have with this search box in 1499514), which would be consistent with about:home. 

The rightward facing arrow as presented in about:home doesn't indicate a "new tab" (since about:home doesn't open new tabs), but neither does the magnifying glass as submit button - at least, it is not obvious to me. It would make more sense to me as a submit button if it were not attached to the text field (more obviously a control, instead of a decoration, like with other search fields).
Attached image no-search-button.PNG (obsolete) —
My patch hides the search button so that it matches about:preferences.
Comment on attachment 9018009 [details]

Just noticed dao's comment. I'll remove the icon on the left instead.
Attachment #9018009 - Attachment is obsolete: true
Here's the fix on Windows now.
Attachment #9018007 - Attachment description: Bug 1499504 - Hide search button in about:addons search on Windows r?jaws → Bug 1499504 - Only add search icon in about:addons search on Mac r?jaws
Attachment #9018007 - Attachment description: Bug 1499504 - Only add search icon in about:addons search on Mac r?jaws → Bug 1499504 - Always include search icon in search boxes on Mac r?dao
Pushed by
Always include search icon in search boxes on Mac r=dao
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
QA Whiteboard: [good first verify]
I Have reproduced this bug with Nightly 64.0a1(2018-10-16) on Windows 10, 64 Bit!
The fix is now verified on latest Beta!

Build ID 	20181108141956
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0
QA Whiteboard: [good first verify] → [good first verify] [testday20180914]
Thank you Tanvir!

Based on comment 11, I will mark this issue as Verified fixed.
You need to log in before you can comment on or make changes to this bug.