1499504 - Magnifying glass icon is positioned to the right of search input instead of left

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P2)

Description

[Asif Youssuff]

Steps to reproduce:

1. Navigate to about:addons
2. Look for input near "Find more extensions"

What happens:

The magnifying glass icon is positioned to the right of the search input. 

Expected result:

The magnifying glass icon should be positioned to the left of the input, like in about:preferences or in the search engine input available in the Firefox toolbar.

Comment 1

[Mark Striemer [:mstriemer]]

I'm guessing this is on Windows, on a Mac both about:addons and about:preferences are on the left.

Comment 2

[Darkspirit]

Attachment: Screenshot_20181016_230612.png

I'm on Debian Testing and have both.

Comment 3

[Dão Gottwald [:dao]]

I believe this bug's summary is wrong. The icon should be on the right because it acts as a submit button. As opposed to other search fields, this one doesn't automatically search while typing.

This rule is messing up the icons: https://searchfox.org/mozilla-central/rev/3d989d097fa35afe19e814c6d5bc2f2bf10867e1/toolkit/themes/shared/extensions/extensions.inc.css#240

Comment 4

[Asif Youssuff]

Dão, maybe it makes sense to use a rightward facing arrow on the right if the "takes you to a new place" affordance is important here, like exists on about:home. 

about:home also uses the search engine icon (and not a magnifying glass), but I think in about:addons at least, it makes sense to be consistent with other search inputs, unless we replace the magnifying glass with an addons.mozilla.org favicon (which would solve another issue I have with this search box in 1499514), which would be consistent with about:home. 

The rightward facing arrow as presented in about:home doesn't indicate a "new tab" (since about:home doesn't open new tabs), but neither does the magnifying glass as submit button - at least, it is not obvious to me. It would make more sense to me as a submit button if it were not attached to the text field (more obviously a control, instead of a decoration, like with other search fields).

Comment 5

[Mark Striemer [:mstriemer]]

Attachment: Bug 1499504 - Always include search icon in search boxes on Mac r?dao

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: no-search-button.PNG

My patch hides the search button so that it matches about:preferences.

Comment 7

[Mark Striemer [:mstriemer]]

Comment on attachment 9018009 [details]
no-search-button.PNG

Just noticed dao's comment. I'll remove the icon on the left instead.

Comment 8

[Mark Striemer [:mstriemer]]

Attachment: no-extra-search-icon.PNG

Here's the fix on Windows now.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a404545425a
Always include search icon in search boxes on Mac r=dao

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/9a404545425a

Comment 11

[Tanvir Rahman]

I Have reproduced this bug with Nightly 64.0a1(2018-10-16) on Windows 10, 64 Bit!
The fix is now verified on latest Beta!

Build ID 	20181108141956
User Agent 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:64.0) Gecko/20100101 Firefox/64.0

Comment 12

[Anca Soncutean, Desktop QA]

Thank you Tanvir!

Based on comment 11, I will mark this issue as Verified fixed.