Closed
Bug 1499648
Opened 6 years ago
Closed 5 years ago
Make search alias (@ token alias) formatting work with UrlbarView
Categories
(Firefox :: Address Bar, enhancement, P2)
Firefox
Address Bar
Tracking
()
RESOLVED
FIXED
Firefox 67
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: dao, Assigned: adw)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
This is currently disabled because this.urlbarInput.popup doesn't exist (there's UrlbarInput::panel and UrlbarInput::view), but more fundamentally I think we're missing APIs such as popup.selectedIndex and popup.oneOffSearchButtons. https://searchfox.org/mozilla-central/rev/3d989d097fa35afe19e814c6d5bc2f2bf10867e1/browser/components/urlbar/UrlbarValueFormatter.jsm#275,286,289
|
||
Updated•6 years ago
|
Blocks: quantumbar-nightly-experiment
|
|
||
Updated•6 years ago
|
Summary: Make search alias formatting work with UrlbarView → Make search alias (@ token alias) formatting work with UrlbarView
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → adw
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 2•6 years ago
|
||
assertHighlighted() in browser_urlbarTokenAlias.js currently skips its check in quantumbar, so that needs to be fixed along with this bug.
|
Reporter | |
Updated•6 years ago
|
|
|
Assignee | |
Comment 3•5 years ago
|
||
This is based on bugs 1528430, 1527947, and 1527934.
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0dbdcaebed42 Make search alias (@ token alias) formatting work with UrlbarView. r=dao
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox67:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in
before you can comment on or make changes to this bug.
Description
•