1500375 - [remote-dbg-next] migrate aboutdebugging test: browser_addons_debug_webextension.js

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Julian Descottes [:jdescottes]]

Migrate https://searchfox.org/mozilla-central/source/devtools/client/aboutdebugging/test/browser_addons_debug_webextension.js to the new about:debugging

Comment 1

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 2

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 3

[Julian Descottes [:jdescottes]]

filter on remote-debugging-next-move-m3-to-m2

Comment 4

[Julian Descottes [:jdescottes]]

You can have a look at the following documentation for some tips on how to migrate tests: https://gist.github.com/juliandescottes/fecc426ac84600357259bf513cea744c

Comment 5

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500375 - Support path or file when installing temporary addon in test;r=daisuke,ola

Small refactor that will be useful for the upcoming patches were we install
temporary extensions from existing XPI files

Comment 6

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500375 - Rename installRegularAddon to installRegularExtension;r=daisuke,ola

Depends on D17053 . Just renaming and moving the helper for consistency

Comment 7

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500375 - Switch to XPI based helper to install fake extensions;r=daisuke,ola

Depends on D17054

The previous version only relied on a manifest, but it's not really flexible.
The XPI approach allows to define background scripts, which can be useful for
more tests.

Note: the old about:debugging supports both the manifest and the XPI approaches
but we should try to keep only one here to make it less complicated to write new
tests.

Comment 8

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500375 - Migrate browser_addons_debug_webextension.js to new about:debugging;r=daisuke,ola

Depends on D17055

Added console to the name, otherwise a straightforward migration normally.

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500375 - Add webextensions tag to migrated extensions debug tests;r=rpl

Depends on D17056

We started migrating the about:debugging tests to the new about:debugging folder.
I guess we should still apply the webextensions tag to them?

Comment 10

[Julian Descottes [:jdescottes]]

try at https://treeherder.mozilla.org/#/jobs?repo=try&revision=b5e26bc7a10b75cfae1d66c687b9bb820dfe69d0

Comment 11

[Julian Descottes [:jdescottes]]

Attachment: Bug 1500375 - Skip addon temporary buttons test on Windows;r=daisuke,ola

Depends on D17055
Sadly on Windows loading a temporary addon as an XPI will lock the file.
This means we cannot update the addon during the test and we cannot test
the reload feature on windows.

The only other solution I can see is to add again the alternate API using
the TemporaryExtension helper to install an "exploded" temporary extension.
I would really like to avoid that, I feel like it's already complicated to
know which method to use in order to install extensions, between temporary
extensions, regular extensions, file based extensions... I would like to
avoid adding yet another method just for one test.

Let me know what you think.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce48248ceaf8
Support path or file when installing temporary addon in test;r=daisuke,Ola
https://hg.mozilla.org/integration/autoland/rev/17f82957f62c
Rename installRegularAddon to installRegularExtension;r=daisuke,Ola
https://hg.mozilla.org/integration/autoland/rev/1b45bc69411d
Switch to XPI based helper to install fake extensions;r=daisuke,Ola
https://hg.mozilla.org/integration/autoland/rev/2b7b8078a63a
Skip addon temporary buttons test on Windows;r=daisuke,Ola
https://hg.mozilla.org/integration/autoland/rev/c1bcc87a8c68
Migrate browser_addons_debug_webextension.js to new about:debugging;r=daisuke,Ola
https://hg.mozilla.org/integration/autoland/rev/4935a429a2b7
Add webextensions tag to migrated extensions debug tests;r=rpl

Comment 13

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ce48248ceaf8
https://hg.mozilla.org/mozilla-central/rev/17f82957f62c
https://hg.mozilla.org/mozilla-central/rev/1b45bc69411d
https://hg.mozilla.org/mozilla-central/rev/2b7b8078a63a
https://hg.mozilla.org/mozilla-central/rev/c1bcc87a8c68
https://hg.mozilla.org/mozilla-central/rev/4935a429a2b7