Open Bug 1500440 Opened 6 years ago Updated 2 years ago

[mac] about profiles section scrolls up while interacting with some of the buttons related to each profile

Categories

(Toolkit :: Startup and Profile System, defect, P3)

All
macOS
defect

Tracking

()

Tracking Status
firefox62 --- unaffected
firefox63 --- unaffected
firefox64 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- fix-optional
firefox70 --- fix-optional

People

(Reporter: obotisan, Unassigned)

References

Details

(Keywords: regression)

Attachments

(1 file)

[Affected versions]:
- DevEd 64.0b2
- Nightly 64.0a1 

[Affected platforms]:
- macOS 10.12
- macOS 10.13
- macOS 10.14

[Prerequisites]:
Have at least 10 profiles in about:profiles list.

[Steps to reproduce]:
1. Go to about:profiles
2. Select the last proflile on the list and click on the "Rename" button.
3. Rename the profile and click "OK". 

[Expected result]:
- The profile is still in view.

[Actual result]:
- The page jumps up at least 5 sections.

[Regression range]:
- If there is a regression I will find it as soon as possible.

[Additional notes]:
- Please look at the attached gif to see the issue reproducing.
- This behaviour happens when you try to "Remove" or "Set as default profile".
The issue is not reproducing on RC 63.0, so this is a recent regression.
I suspect this is a regression from bug 1486935, though a regression window would be really helpful to confirm this.

Mihai, seems Oana's account has been disabled, who could look for a regression window here?
Flags: needinfo?(mihai.boldan)
Hi,

Here is the Regression Range I found for this issue:

INFO: Last good revision: a5d7a71300f8000625634d67ce5cd242e5e8e4d9
INFO: First bad revision: 5e43b977f631d6889a63deb281cec2445b7ac67e

INFO: Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=a5d7a71300f8000625634d67ce5cd242e5e8e4d9&tochange=5e43b977f631d6889a63deb281cec2445b7ac67e
Thanks! Yeah, I think this is a result of the async nature of fluent and the fact that `refreshUI` essentially clears the page and then reconstructs it.

This doesn't seem very severe, so I don't think we need to track for 64 - about:profiles is barely-if-at-all exposed, and hopefully not in daily use by lots of people, plus of course this isn't actually any broken functionality, just glitchiness.

All the same, if we could come up with a fix that'd be good. The problem I see is that all the fixes I can think of aren't very straightforward:

- maybe more consistently call l10n.setAttributes before inserting the node into the DOM (would that help?)
- put some dummy value in the localized attributes (to be overwritten by fluent when it gets localized values), and/or set fixed (vertical) sizes on some of the elements.
- fix up the various consumers to only manipulate the relevant entry instead of blanket-calling `refreshUI`.

:stas, can you investigate what specifically is causing the jump here, and what the best way of fixing it would be, given Fluent's async nature? I'm a little worried we might run into this in other (more important) cases as well, or at least need to take it into account when doing other conversions.
Blocks: 1486935
Flags: needinfo?(mihai.boldan) → needinfo?(stas)
Thanks for the ping, Gijs. I haven't worked on fluent-dom in a while now; it might take me a while to get to the bottom of this. I'll leave the needinfo on me and I'll report back when I'm able to figure something out. In the meantime, perhaps Zibi can offer some help about this?
Flags: needinfo?(zbraniecki)
Florian, can you take a look here?
Flags: needinfo?(florian)
I'm not familiar with the work happening in about:profiles, I would expect Mossop to know better.
Flags: needinfo?(florian) → needinfo?(dtownsend)
Flags: needinfo?(stas)
So far there are no specific plans to make any changes to this UI. The way refreshUI works seems poor and should be fixed IMO. But I agree with Gijs that this looks like a low priority. The number of people opening about:profiles is small and this bug only impacts users who have more profiles than can fit on the screen (99.8% of beta users have 3 or less profiles).
Flags: needinfo?(dtownsend)
Priority: -- → P3

Bulk change to wontfix for 68 (P3+ carryover with needinfo).

Flags: needinfo?(zbraniecki)

The issue is still reproducible on the latest Nightly version (69.0a1).

Happy to take a patch for 70 but since this is triaged and set to P3 priority I'm setting it as fix-optional.
That will remove the bug from weekly regression triage.

Severity: minor → S4
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: