Reject building with macOS 10.14 SDK

RESOLVED FIXED in Firefox 66

Status

enhancement
P2
normal
RESOLVED FIXED
7 months ago
a month ago

People

(Reporter: spohl, Assigned: mshal)

Tracking

(Depends on 1 bug, Blocks 2 bugs)

unspecified
mozilla66
Desktop
macOS
Dependency tree / graph

Firefox Tracking Flags

(firefox66 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

7 months ago
We should reject building with the macOS 10.14 SDK until all major compatibility issues (such as bug 1494022) are fixed. We should help developers find an older SDK, or even better, help them find the 10.11 SDK which is used in automation.

Updated

7 months ago
Keywords: in-triage
We'd be happy to help someone write a patch for this.

Updated

7 months ago
Priority: P1 → P4
Please add my vote to find a fix for this.  Just spent 80 minutes on 2 separate OSX builds only to find that it is a known sdk issues.

Updated

4 months ago
Priority: P4 → P2
Assignee

Comment 3

4 months ago

I'll take this, it doesn't seem too hard to pull the version info from SDKSettings.plist.

What min/max version numbers do we want? I assume min=10.11, and max is 10.13?

Assignee: nobody → mshal
Assignee

Comment 4

4 months ago
In bug 1494022 there are problems using an SDK that is too new, which
can cause developers to spend many hours debugging an issue that we
could've checked up front.

This patch gets the version from the SDKSettings.plist file at the root
of the SDK directory, and checks it against min and max supported
versions.

The current min version is 10.11, since that is what we build with in
automation. The current max version is 10.13, since 10.14+ currently has
an issue with a black screen at startup.

Comment 5

4 months ago
Pushed by mshal@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4195353da58d
Add version checks for the OSX SDK; r=froydnj#firefox-build-system-reviewers

Comment 6

4 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66
Depends on: 1520127

Comment 7

a month ago

Thing is, if you install the latest version of Xcode, 10.14 SDK is all you get. Xcode does not include 10.13 or 10.11 SDK anymore. So, how should you build if you block the only available SDK? I don't know of any page where you can download old SDKs from Apple.

Reporter

Comment 8

a month ago

(In reply to Nomis101 from comment #7)

Thing is, if you install the latest version of Xcode, 10.14 SDK is all you get. Xcode does not include 10.13 or 10.11 SDK anymore. So, how should you build if you block the only available SDK? I don't know of any page where you can download old SDKs from Apple.

The official way to get a hold of an older SDK is by installing an older XCode from https://developer.apple.com/download/.

Comment 9

a month ago

OK, thanks.

You need to log in before you can comment on or make changes to this bug.