1522986 - Teach `mach bootstrap` how to verify and install macOS SDK and required headers

Status: RESOLVED FIXED

(Firefox Build System :: Bootstrap Configuration, enhancement)

Description

[Nick Alexander :nalexander [he/him]]

Bug 1500504 made mach configure check for valid macOS SDK versions -- but we don't install them for you in mach bootstrap.

Bug 1495610 shows how to work around build errors by installing headers from some package -- but we don't install them for you in mach bootstrap.

This ticket tracks making both of those things better.

Comment 1

[(not currently active) Ted Mielczarek]

I don't think we can install an arbitrary version of a macOS SDK in an automated way unfortunately. SDKs ship as part of XCode, and I don't believe the license allows for redistribution.

Comment 2

[Nick Alexander :nalexander [he/him]]

(In reply to Ted Mielczarek [:ted] [:ted.mielczarek] from comment #1)

I don't think we can install an arbitrary version of a macOS SDK in an automated way unfortunately. SDKs ship as part of XCode, and I don't believe the license allows for redistribution.

I think that's correct, but https://github.com/phracker/MacOSX-SDKs/releases is playing fast and loose with those rules. I'm not concerned about enabling this potential infringement via glue code in mach bootstrap.

Comment 3

[Mark Banner (:standard8)]

Could we at least get bootstrap (or configure in the case of headers) to detect they're missing and ask the developer to install them/run the commands?

I've just hit on this the long way, and I'm sure other people will be.

Comment 4

[Dave Townsend [:mossop]]

It seems that there is now no straightforward way of installing the SDK headers: bug 1569003

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1522986 - Move the macos SDK download and validation to the unpack-sdk script.

At the same time, make the pack.sh script more verbose.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Bug 1522986 - Automatically wrap private local toolchains.

Comment 7

[Mike Hommey [:glandium]]

Attachment: Bug 1522986 - Add auto-bootstrap support for private local toolchains.

Per the previous commit, the task definitions now can be used to get a
command that can be used to generate the toolchain locally.

Comment 8

[Mike Hommey [:glandium]]

Attachment: Bug 1522986 - Allow to auto-bootstrap the macos SDK.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9eec26499feb
Move the macos SDK download and validation to the unpack-sdk script. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/865a03294e4b
Automatically wrap private local toolchains. r=taskgraph-reviewers,hneiva,firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/bc898a3a5165
Add auto-bootstrap support for private local toolchains. r=firefox-build-system-reviewers,ahochheiden
https://hg.mozilla.org/integration/autoland/rev/697accbb8a41
Allow to auto-bootstrap the macos SDK. r=firefox-build-system-reviewers,ahochheiden

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/9eec26499feb
https://hg.mozilla.org/mozilla-central/rev/865a03294e4b
https://hg.mozilla.org/mozilla-central/rev/bc898a3a5165
https://hg.mozilla.org/mozilla-central/rev/697accbb8a41