1500733 - Remove FoxEye ImageBitmap extensions?

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrea Marchesini [:baku]]

Can we remove these extensions:

https://searchfox.org/mozilla-central/rev/4fc7bfa931189e0718dd70b4c59885829f1d761e/dom/webidl/ImageBitmap.webidl#14

https://searchfox.org/mozilla-central/rev/4fc7bfa931189e0718dd70b4c59885829f1d761e/dom/webidl/WindowOrWorkerGlobalScope.webidl#72

It seems that FoxEye project has been terminated but we still have this code in the tree.

Comment 1

[Andrea Marchesini [:baku]]

Attachment: part 1 - remove BufferSource support

This is not part of the spec and it's not actually supported. We throw a "Not implemented" error.

Comment 2

[Andrea Marchesini [:baku]]

Attachment: part 1 - remove BufferSource support

Comment 3

[Andrea Marchesini [:baku]]

Attachment: part 2 - Remove ImageBitmap.mapDataInto

Comment 4

[Andrea Marchesini [:baku]]

Attachment: part 3 - Remove ImageBitmap.mappedDataLength

Comment 5

[Andrea Marchesini [:baku]]

Attachment: part 4 - Remove ImageBitmap.findOptimalFormat

Comment 6

[Andrea Marchesini [:baku]]

Attachment: part 5 - Remove tests

Comment 7

[Andrea Marchesini [:baku]]

Attachment: part 6 - pref

Comment 8

[Boris Zbarsky [PTO through Aug 25, :bzbarsky, bz on IRC]]

It's fine with me to remove this code if the people who added it don't need it anymore.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dac317f3cd31
Remove the support for BufferSource in createImageBitmap, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/3c81d4cb6aea
Remove ImageBitmap.mapDataInto, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/17ac83c08f67
Remove ImageBitmap.mappedDataLength, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/e324b60281dd
Remove ImageBitmap.findOptimalFormat, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b5a4cd42d40
Remove tests, r=aosmond
https://hg.mozilla.org/integration/mozilla-inbound/rev/1dee16fa95e5
Remove canvas.imagebitmap_extensions.enabled preference, r=aosmond

Comment 10

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/dac317f3cd31
https://hg.mozilla.org/mozilla-central/rev/3c81d4cb6aea
https://hg.mozilla.org/mozilla-central/rev/17ac83c08f67
https://hg.mozilla.org/mozilla-central/rev/e324b60281dd
https://hg.mozilla.org/mozilla-central/rev/8b5a4cd42d40
https://hg.mozilla.org/mozilla-central/rev/1dee16fa95e5