1500823 - Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder in Japanese

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Hideki Saito]

Attachment: 2018-10-21_18-56-46.png

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

When Japanese locale is active, open more than one Firefox window, and then attempt to quit Firefox. (Confirmation in Options should be enabled to show this message.)


Actual results:

The multiple window closing confirmation message contains string placeholders "%1$S 2個のウインドウを閉じようとしています。よろしいですか" when closing Firefox while more than one Window is active.


Expected results:

It should not show such placeholder "%1$S", and should only show pertinent message.

Comment 1

[Hideki Saito]

This happened in both RC build 2 installer and portable for 63.0 and with en-US + ja language pack, as well as ja portable package.

Comment 2

[Makoto Kato [:m_kato]]

Here?
https://github.com/mozilla-japan/gecko-l10n/blob/d856b9bb030721736ccf38293642a00f86b51101/ja/browser/chrome/browser/tabbrowser.properties#L42

Comment 3

[Hideki Saito]

Yes, that's the one!

Comment 4

[Francesco Lodolo [:flod]]

Unfortunately we're past the string freeze for 63. 

While this is not a standard getFormattedString call, because of the plural, the code was designed to accept both %S and %1$S.
https://searchfox.org/mozilla-central/rev/0ec9f5972ef3e4a479720630ad7285a03776cdfc/browser/components/nsBrowserGlue.js#1785

The problem is that the regex is wrong

%(?:1$)?S

The $ sign is not escaped

%(?:1\$)?S

Comment 5

[Francesco Lodolo [:flod]]

Attachment: Bug 1500823 - Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6a8240b5c287
Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder r=Gijs

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6a8240b5c287

Comment 8

[Francesco Lodolo [:flod]]

Attachment: 65.0a1 (2018-10-22) (64 ビット)

Does this look correct?

Comment 9

[Hideki Saito]

(In reply to Francesco Lodolo [:flod] from comment #8)
> Created attachment 9019254 [details]
> 65.0a1 (2018-10-22) (64 ビット)
> 
> Does this look correct?

Yes, this looks perfect!

Comment 10

[Francesco Lodolo [:flod]]

Comment on attachment 9018955 [details]
Bug 1500823 - Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1438499

User impact if declined: Warning displayed when closing multiple windows is incorrect for Japanese, and potentially other locales.

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Correcting incorrect regular expression only used to replace a parameter in this string.

String changes made/needed: None

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9018955 [details]
Bug 1500823 - Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder

Fixes a broken warning dialog for Japanese locales (and possibly others). Approved for 64.0b4.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f758524d2acd

Comment 14

[Camelia Badau [:cbadau], Desktop Test Engineering]

I've reproduced the issue on Windows 7 x64, Ubuntu 16.04 x64 and macOS 10.13 using Firefox 63 RC build 2 (ja localization build and en-US + ja language pack).

Verified the issue on Windows 7 x64, Ubuntu 16.04 x64 and macOS 10.13 using latest Nightly 65.0a1 (2018-10-24) with ja, ar, zh-CN, es-ES, de, ru, ko, pt-PT, pl, fr, tr localization builds and with en-US + ja language pack. Everything looks good here.

Comment 15

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 x64, Ubuntu 16.04 x64 and macOS 10.13 using Firefox 64 Beta 4 (buildID: 20181025233934) with ja, ar, de, fr, es-ES, ko, pt-PT, ru, zh-CN localization builds and with en-US + ja language pack.

Comment 17

[Pascal Chevrel:pascalc]

Comment on attachment 9018955 [details]
Bug 1500823 - Dialog displayed when closing multiple windows shows unreplaced %1$S placeholder

Minimal patch, fixed on nightly a week ago, uplifted to beta, had QA, approved for 63.0.1. Thanks

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0dcad68072b5

Comment 19

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed on Windows 7 x64, Ubuntu 16.04 x86 and macOS 10.14 using Firefox 63.0.1 (buildID: 20181030165643) with ja, ar, de, fr, es-ES, ko, pt-PT, ru, zh-CN localization builds and with en-US + ja language pack.