1501024 - WifiScanner should use ApplicationContext

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, enhancement, P1)

Description

[Jan Henning [:JanH]]

Lint complains that not doing so risks a memory leak when getting the WifiManager on Android versions prior to N, and it seems that we indeed currently use the StumberService's context to launch the WifiScanner.

We could fix this at https://dxr.mozilla.org/mozilla-central/rev/c291143e24019097d087f9307e59b49facaf90cb/mobile/android/stumbler/java/org/mozilla/mozstumbler/service/stumblerthread/scanners/WifiScanner.java#60 by calling getApplicationContext() on the context that gets passed in there.

Comment 1

[Liz Henry (:lizzard) (relman/hg->git project)]

Fixing a possible memory leak sounds like a good idea - tentatively calling this a P1

Comment 2

[Andrei Lazar]

Attachment: Bug 1501024 WifiScanner should use ApplicationContext r=JanH

Fixed lint warning regarding memory leak inside WifiManager constructor.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f37c64ae423
WifiScanner should use ApplicationContext r=JanH

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/6f37c64ae423

Comment 5

[Andrei Lazar]

I modified the initial patch so I've added the 2nd check-in needed as a follow-up.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c85e2fe3af3b
WifiScanner should use ApplicationContext r=JanH

Comment 7

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f9ef4b24affa

Comment 8

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c85e2fe3af3b