1510663 - Lint Warning: WifiManagerLeak

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P1)

Description

[Emily Toop (:fluffyemily)]

On versions prior to Android N (24), initializing the WifiManager via Context#getSystemService can cause a memory leak if the context is not the application context.  

In many cases, it's not obvious from the code where the Context is coming from (e.g. it might be a parameter to a method, or a field initialized from various method calls). It's possible that the context being passed in is the application context, but to be on the safe side, you should consider changing context.getSystemService(...) to context.getApplicationContext().getSystemService(...).

Affected Class:

GeckoNetworkManager

Comment 1

[Emily Toop (:fluffyemily)]

Attachment: Address WifiManager Potential Leak warning.

On versions prior to Android N (24), initializing the WifiManager via Context#getSystemService can cause a memory leak if the context is not the application context.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d02e6cc785a9
Address WifiManager Potential Leak warning. r=geckoview-reviewers,snorp

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/d02e6cc785a9

Comment 4

[Chris Peterson [:cpeterson]]

65=wontfix