Remove the browser.contentblocking.ui.enabled pref

VERIFIED FIXED in Firefox 65

Status

()

P1
normal
VERIFIED FIXED
5 months ago
5 months ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
Firefox 65
Points:
---

Firefox Tracking Flags

(firefox65 verified)

Details

(Whiteboard: [privacy65])

Attachments

(5 attachments)

(Assignee)

Description

5 months ago
Now that we have shipped the content blocking UI and we're on the 65 train, it's time to remove the browser.contentblocking.ui.enabled pref to simplify the code a little bit.  These patches shouldn't change the functionality at all, and just remove the existing code which is disabled behind this pref and the associated tests.
Priority: -- → P1
Whiteboard: [privacy65]

Comment 6

5 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/93d6f4d54f78
Part 1: Remove support for the tracking protection UI from Preferences r=flod,johannh
https://hg.mozilla.org/integration/autoland/rev/ca6c3139bdd2
Part 2: Remove support for tracking protection UI from Control Centre r=johannh
https://hg.mozilla.org/integration/autoland/rev/d9940451c373
Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
https://hg.mozilla.org/integration/autoland/rev/578d395f555e
Part 4: Remove the browser.contentblocking.ui.enabled pref from several tests which now set it needlessly r=johannh
https://hg.mozilla.org/integration/autoland/rev/cac0d4aa79d1
Part 5: Remove the browser.contentblocking.ui.enabled pref r=johannh
Backed out 5 changesets (bug 1501286) for browser-chrome failures in browser/components/uitour/test/browser_trackingProtection.js

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=207778968&repo=autoland&lineNumber=4982

INFO - TEST-START | browser/base/content/test/trackingUI/browser_trackingUI_appMenu_toggle.js
[task 2018-10-25T14:21:36.040Z] 14:21:36     INFO - TEST-INFO | started process screentopng
[task 2018-10-25T14:21:36.839Z] 14:21:36     INFO - TEST-INFO | screentopng: exit 0
[task 2018-10-25T14:21:36.839Z] 14:21:36     INFO - Buffered messages logged at 14:20:51
[task 2018-10-25T14:21:36.839Z] 14:21:36     INFO - Entering test bound testGlobalToggle
[task 2018-10-25T14:21:36.839Z] 14:21:36     INFO - Opening main menu
[task 2018-10-25T14:21:36.840Z] 14:21:36     INFO - Buffered messages finished
[task 2018-10-25T14:21:36.841Z] 14:21:36     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/trackingUI/browser_trackingUI_appMenu_toggle.js | Test timed out - 
[task 2018-10-25T14:21:36.842Z] 14:21:36     INFO - GECKO(11771) | MEMORY STAT | vsize 1805MB | residentFast 261MB | heapAllocated 85MB
[task 2018-10-25T14:21:36.843Z] 14:21:36     INFO - TEST-OK | browser/base/content/test/trackingUI/browser_trackingUI_appMenu_toggle.js | took 45025ms
[task 2018-10-25T14:21:36.844Z] 14:21:36     INFO - checking window state
[task 2018-10-25T14:21:37.783Z] 14:21:37     INFO - GECKO(11771) | Completed ShutdownLeaks collections in process 11936
[task 2018-10-25T14:21:37.819Z] 14:21:37     INFO - GECKO(11771) | Completed ShutdownLeaks collections in process 12004
[task 2018-10-25T14:21:37.836Z] 14:21:37     INFO - GECKO(11771) | Completed ShutdownLeaks collections in process 11982
[task 2018-10-25T14:21:37.865Z] 14:21:37     INFO - GECKO(11771) | Completed ShutdownLeaks collections in process 11859
[task 2018-10-25T14:21:37.875Z] 14:21:37     INFO - GECKO(11771) | Completed ShutdownLeaks collections in process 11880
[task 2018-10-25T14:21:38.261Z] 14:21:38     INFO - GECKO(11771) | Completed ShutdownLeaks collections in process 11771
[task 2018-10-25T14:21:38.262Z] 14:21:38     INFO - TEST-START | Shutdown
[task 2018-10-25T14:21:38.263Z] 14:21:38     INFO - Browser Chrome Test Summary
[task 2018-10-25T14:21:38.265Z] 14:21:38     INFO - Passed:  2
[task 2018-10-25T14:21:38.266Z] 14:21:38     INFO - Failed:  1
[task 2018-10-25T14:21:38.271Z] 14:21:38     INFO - Todo:    0
[task 2018-10-25T14:21:38.275Z] 14:21:38     INFO - Mode:    e10s
[task 2018-10-25T14:21:38.279Z] 14:21:38     INFO - *** End BrowserChrome Test Results ***

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=cac0d4aa79d1888f8b8886512be2b7d6b521c6d5

Backout:
https://hg.mozilla.org/integration/autoland/rev/5e471c480b8a6ba4939a6c159d86a687a24bb5d8
Flags: needinfo?(ehsan)
(Assignee)

Updated

5 months ago
Flags: needinfo?(ehsan)

Comment 8

5 months ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6b6d4cec073
Part 1: Remove support for the tracking protection UI from Preferences r=flod,johannh
https://hg.mozilla.org/integration/autoland/rev/f43f531c5a27
Part 2: Remove support for tracking protection UI from Control Centre r=johannh
https://hg.mozilla.org/integration/autoland/rev/cdccbbffdd8d
Part 3: Remove support for tracking protection UI in about:privatebrowsing r=johannh
https://hg.mozilla.org/integration/autoland/rev/f637a53317e6
Part 4: Remove the browser.contentblocking.ui.enabled pref from several tests which now set it needlessly r=johannh
https://hg.mozilla.org/integration/autoland/rev/92fead125b51
Part 5: Remove the browser.contentblocking.ui.enabled pref r=johannh

Comment 10

5 months ago
Verified the issue on Nightly 65.0a1 (2018-11-11).
Status: RESOLVED → VERIFIED
status-firefox65: fixed → verified
You need to log in before you can comment on or make changes to this bug.