Closed Bug 1561184 Opened 2 years ago Closed 2 years ago

tooltip for tracking protection/content blocking in app menu not shown

Categories

(Firefox :: Protections UI, defect, P3)

All
Unspecified
defect

Tracking

()

VERIFIED FIXED
Firefox 71
Tracking Status
firefox-esr60 --- unaffected
firefox-esr68 --- wontfix
firefox67 --- wontfix
firefox68 --- wontfix
firefox69 --- wontfix
firefox70 --- wontfix
firefox71 --- verified

People

(Reporter: aryx, Assigned: ewright)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [protection-report][skyline])

Attachments

(1 file)

Firefox 65+, tested with 68.0b12 and Firefox 69.0a1 20190624213657 on Windows 8.1

The tooltip for tracking protection/content blocking in the app menu is not shown.

Steps to reproduce:

  1. Open app menu: Click button with three vertical lines at right of toolbar.
  2. Move mouse over the text "Content blocking".

Actual result: No tooltip

Expected result: Tooltip "Open Content Blocking Options/Preferences" (contentBlocking.tooltipWin, contentBlocking.tooltipOther)

We should probably fix this when doing bug 1563547

Depends on: 1563547
Keywords: regression
Priority: -- → P2

(In reply to Johann Hofmann [:johannh] from comment #1)

We should probably fix this when doing bug 1563547

Did we? :)

Uhm, nope, haha. OTOH I don't see any other hover tooltips in the app menu either, so maybe we can just INVALID this. We'll talk about it in triage.

Flags: needinfo?(jhofmann)
Priority: P2 → --
Whiteboard: [protection-report][skyline]

We do have a tooltiptext attribute. If we want it to show up, we have to move it out of the label into the toolbarbutton. But none of the other buttons have a tooltip, as mentioned. Do we need this?

Also, why is this tooltip set dynamically and not via a .DTD.

Priority: -- → P3
Assignee: nobody → ewright
Status: NEW → ASSIGNED

Still happy to take a patch in early beta (until the end of next week), just let me know if you land this and think it is worth uplift for 70 release.

(In reply to Liz Henry (:lizzard) from comment #6)

Still happy to take a patch in early beta (until the end of next week), just let me know if you land this and think it is worth uplift for 70 release.

Thanks, I think this is fairly low priority and we are moving some strings around, I'll confirm with l10n and possibly ask for uplift.

Flags: needinfo?(ewright)
Pushed by ewright@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b4e9677c516
Show tooltip text for protection report in app menu r=fluent-reviewers,johannh,flod
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 71
Depends on: 1584573
Flags: qe-verify+

Confirmed issue with 69.0a1 (2019-06-24).
Fix verified with 71.0b4 on Windows 10, Ubuntu 18.04 and 71.0b3 on macOS 10.14.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Hardware: Unspecified → All
You need to log in before you can comment on or make changes to this bug.