1561184 - tooltip for tracking protection/content blocking in app menu not shown

Status: VERIFIED FIXED

(Firefox :: Protections UI, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox 65+, tested with 68.0b12 and Firefox 69.0a1 20190624213657 on Windows 8.1

The tooltip for tracking protection/content blocking in the app menu is not shown.

Steps to reproduce:

1. Open app menu: Click button with three vertical lines at right of toolbar.
2. Move mouse over the text "Content blocking".

Actual result: No tooltip

Expected result: Tooltip "Open Content Blocking Options/Preferences" (contentBlocking.tooltipWin, contentBlocking.tooltipOther)

Comment 1

[Johann Hofmann [:johannh]]

We should probably fix this when doing bug 1563547

Comment 2

[Ryan VanderMeulen [:RyanVM]]

(In reply to Johann Hofmann [:johannh] from comment #1)

We should probably fix this when doing bug 1563547

Did we? :)

Comment 3

[Johann Hofmann [:johannh]]

Uhm, nope, haha. OTOH I don't see any other hover tooltips in the app menu either, so maybe we can just INVALID this. We'll talk about it in triage.

Comment 4

[Johann Hofmann [:johannh]]

We do have a tooltiptext attribute. If we want it to show up, we have to move it out of the label into the toolbarbutton. But none of the other buttons have a tooltip, as mentioned. Do we need this?

Also, why is this tooltip set dynamically and not via a .DTD.

Comment 5

[Erica Wright [:ewright]]

Attachment: Bug 1561184 - Show tooltip text for protection report in app menu

Comment 6

[Liz Henry (:lizzard) (relman/hg->git project)]

Still happy to take a patch in early beta (until the end of next week), just let me know if you land this and think it is worth uplift for 70 release.

Comment 7

[Erica Wright [:ewright]]

(In reply to Liz Henry (:lizzard) from comment #6)

Still happy to take a patch in early beta (until the end of next week), just let me know if you land this and think it is worth uplift for 70 release.

Thanks, I think this is fairly low priority and we are moving some strings around, I'll confirm with l10n and possibly ask for uplift.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b4e9677c516
Show tooltip text for protection report in app menu r=fluent-reviewers,johannh,flod

Comment 9

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/1b4e9677c516

Comment 10

[Cristian Fogel [:cfogel]]

Confirmed issue with 69.0a1 (2019-06-24).
Fix verified with 71.0b4 on Windows 10, Ubuntu 18.04 and 71.0b3 on macOS 10.14.