Closed Bug 1501518 Opened 3 years ago Closed 3 years ago
_ready() panic because the render target texture is smaller than max _size
46 bytes, text/x-phabricator-request
|Details | Review|
This is a regression from bug 1501073. I hit a panic on . Patch forthcoming.  https://projects.fivethirtyeight.com/2018-midterm-election-forecast/house/?ex_cid=rrpromo
Err, I think I hit it on https://projects.fivethirtyeight.com/trump-approval-ratings/?ex_cid=rrpromo
(A commit message, which I just added): Previously, we sized all render target textures using max_size. This changed, and now we size them based on the union of the allocator's used_rect for each slice. At present, the code updates max_size for every render task. But it's only used to size the per-slice allocators, which in turn are only used for RenderTaskLocation::Dynamic. Accounting for this fixes a panic (wherein check_ready can fail because the texture is smaller than max_size) and also allows more-efficient render target texture sizing.
Green try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e0b2260f5bc285c6d648b609767992209c78491 This merged on github, waiting for it to hit m-c.
Is it possible/worth writing a crash test for this?
3 years ago
Verified fixed in the latest osx nightly.
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/d3e5a0aa6867 Crashtest. r=kvark
You need to log in before you can comment on or make changes to this bug.