1501518 - check_ready() panic because the render target texture is smaller than max_size

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Bobby Holley (:bholley)]

This is a regression from bug 1501073. I hit a panic on [1]. Patch forthcoming.

[1] https://projects.fivethirtyeight.com/2018-midterm-election-forecast/house/?ex_cid=rrpromo

Comment 1

[Bobby Holley (:bholley)]

Err, I think I hit it on https://projects.fivethirtyeight.com/trump-approval-ratings/?ex_cid=rrpromo

Comment 2

[Bobby Holley (:bholley)]

Attachment: Bug 1501518 - Don't update max_size for tasks drawn into the texture cache.

Comment 3

[Bobby Holley (:bholley)]

(A commit message, which I just added):

    Previously, we sized all render target textures using max_size. This
    changed, and now we size them based on the union of the allocator's used_rect
    for each slice.
    
    At present, the code updates max_size for every render task. But it's
    only used to size the per-slice allocators, which in turn are only used
    for RenderTaskLocation::Dynamic. Accounting for this fixes a panic
    (wherein check_ready can fail because the texture is smaller than
    max_size) and also allows more-efficient render target texture sizing.

Comment 4

[Bobby Holley (:bholley)]

https://github.com/servo/webrender/pull/3226

Comment 5

[Bobby Holley (:bholley)]

Green try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e0b2260f5bc285c6d648b609767992209c78491

This merged on github, waiting for it to hit m-c.

Comment 6

[Kartikaya Gupta (email:[e-mail])]

Is it possible/worth writing a crash test for this?

Comment 7

[Bobby Holley (:bholley)]

Verified fixed in the latest osx nightly.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3e5a0aa6867
Crashtest. r=kvark

Comment 9

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/d3e5a0aa6867