1501552 - Link directly to permission preferences from web notifications instead of just #privacy

Status: VERIFIED FIXED

(Toolkit Graveyard :: Notifications and Alerts, defect, P1)

Description

[Matthew N. [:MattN]]

Due to all the new content blocking content at the top of about:preferences#privacy, we should deep-link to the relevant section of the page. The ability to link to a section wasn't available when this was implemented.

Comment 1

[Matthew N. [:MattN]]

Attachment: Bug 1501552 - Link directly to permission preferences from web notifications. r?jaws

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/481aad44be65
Link directly to permission preferences from web notifications. r=jaws

Comment 3

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/481aad44be65

Comment 4

[Ryan VanderMeulen [:RyanVM]]

I assume this can ride the trains, but feel free to nominate for Beta uplift if you feel strongly otherwise.

Comment 5

[Matthew N. [:MattN]]

Comment on attachment 9019581 [details]
Bug 1501552 - Link directly to permission preferences from web notifications. r?jaws

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Preferences re-org for content blocking and prior

User impact if declined: Choosing to open settings from a web notification will take the user to the top of about:preferences#privacy which is very confusing and not helpful

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): Trivial one-line patch to deep-link into the right part of preferences

String changes made/needed: None

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9019581 [details]
Bug 1501552 - Link directly to permission preferences from web notifications. r?jaws

I guess that answers that then! Improves confusing UX around permission preferences, approved for 64.0b4.

Comment 7

[Matthew N. [:MattN]]

Yeah, it's trivial and early in the cycle so I figured we should uplift.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/221f5453ccfb

Comment 9

[Adrian Florinescu [:aflorinescu]]

Tested and verified as follows, using test notification from: https://davidwalsh.name/demo/notifications-api.php

versions:
65.0a1  2018-11-01
64.0b6  2018-11-01  

platforms:
OSX 10.13 
Ubuntu 16.04 x64
Windows 10, Windows 8x32, Windows 8.1 x64, Windows 7 x32


While testing this change, encountered a few weird situations in which:
1. On Windows 10/Nightly 2018-11-01, the web notifications looks like this:  https://imgur.com/a/3pyP5QE - this doesn't reproduces for 64.0b6/2018-11-01  or  63.0.1/2018-10-30 ->  https://imgur.com/a/an6ZxaU
2. On a Windows 8.1 machine, the upgraded build (I think it was from a 60Nightly) would refuse to show the web notification at all -> however, on a clean install it would work.
3. On a different Windows 8.1 x32, the web notification would be displayed, but without having any of the preferences options. On a new Nightly installation, the notification would not be shown at all again.


Since this issue treats the redirect from the settings, I will mark this issue as verified for 65.0a1 and 64.0b6 and I will log a separate bug for 2 and 3.  Matt, any ideas how to get some debug logs on this?

Comment 10

[Matthew N. [:MattN]]

(In reply to Adrian Florinescu [:adrian_sv] from comment #9)
> While testing this change, encountered a few weird situations in which:
> 1. On Windows 10/Nightly 2018-11-01, the web notifications looks like this: 
> https://imgur.com/a/3pyP5QE - this doesn't reproduces for 64.0b6/2018-11-01 
> or  63.0.1/2018-10-30 ->  https://imgur.com/a/an6ZxaU

https://imgur.com/a/an6ZxaU is the expected look on non-Nightly due to bug 1497425 not being resolved yet.

> 2. On a Windows 8.1 machine, the upgraded build (I think it was from a
> 60Nightly) would refuse to show the web notification at all -> however, on a
> clean install it would work.

Make sure you didn't have Do Not Disturb on in preferences.

Otherwise for logs you could try a debug build and start it from the command line to get logging:
1) https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&searchStr=windows%2C2012%2Cx64%2Cdebug%2Cbuild-win64%2Fdebug%2C%28b%29&selectedJob=209348132
2) Click a "B"
3) "Job Details" tab
4) Download "artifact uploaded: target.zip" and run.

> 3. On a different Windows 8.1 x32, the web notification would be displayed,
> but without having any of the preferences options. On a new Nightly
> installation, the notification would not be shown at all again.

I guess that wasn't the ones that look like https://imgur.com/a/an6ZxaU then? That seems like something that should block bug 1497425 probably then as I don't think Win 8.1 has an action center though I could be wrong. I only saw the options in the Windows 10 action center with the native notificafions.

See above about getting logs and see bug 1497425 dependencies for existing issues with the native notifications.