Add space before <label> in legacy-extensions-description

RESOLVED FIXED in Firefox 65

Status

()

enhancement
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: flod, Assigned: flod)

Tracking

unspecified
mozilla65
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

I think we ended up removing one space too many

The string currently looks like this

legacy-extensions-description = 
    These extensions do not meet current { -brand-short-name } standards so they have been deactivated.<label data-l10n-name="legacy-learn-more">Learn about the changes to add-ons</label>

Notice the lack of space before the <label> element.

This used to be

<label id="legacy-extensions-heading" value="&legacyExtensions.title;"/>
  <description>
    &legacyExtensions.description;
    <label class="text-link plain" id="legacy-learnmore">&legacyExtensions.learnMore;</label>
</description>

So the new line was collapsed into a white space.
Side thoughts:
* The diff is going to be larger because there are a ton of trailing whitespaces in the FTL
* The Python file is using Windows line ending (I didn't touch that)

@Colin
You should double check your text editor settings, to remove trailing whitespaces and use Unix line endings.
https://hg.mozilla.org/mozilla-central/rev/a0509a9b9a06
Status: NEW → RESOLVED
Closed: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
It was just the legacy extensions description?
Attachment #9019911 - Attachment is obsolete: true
Attachment #9019911 - Attachment is obsolete: false
Attachment #9019911 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.