1501581 - Add space before <label> in legacy-extensions-description

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, enhancement)

Description

[Francesco Lodolo [:flod]]

I think we ended up removing one space too many

The string currently looks like this

legacy-extensions-description = 
    These extensions do not meet current { -brand-short-name } standards so they have been deactivated.<label data-l10n-name="legacy-learn-more">Learn about the changes to add-ons</label>

Notice the lack of space before the <label> element.

This used to be

<label id="legacy-extensions-heading" value="&legacyExtensions.title;"/>
  <description>
    &legacyExtensions.description;
    <label class="text-link plain" id="legacy-learnmore">&legacyExtensions.learnMore;</label>
</description>

So the new line was collapsed into a white space.

Comment 1

[Francesco Lodolo [:flod]]

Side thoughts:
* The diff is going to be larger because there are a ton of trailing whitespaces in the FTL
* The Python file is using Windows line ending (I didn't touch that)

@Colin
You should double check your text editor settings, to remove trailing whitespaces and use Unix line endings.

Comment 2

[Francesco Lodolo [:flod]]

Attachment: Bug 1501581 - Add space before <label> in legacy-extensions-description

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0509a9b9a06
r=Gijs,Pike

Comment 4

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/a0509a9b9a06

Comment 5

[Collin Wing]

It was just the legacy extensions description?

Comment 6

[Collin Wing]

Attachment: Bug 1501581 Add space before <label> in legacy-extensions-description