1501688 - Temporary files generated by opening external files with content:// scheme should be sanitized

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Comment 1

[Andrei Lazar]

Attachment: Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH

Implemented cache sanitizing for files generated by handling the content:// scheme.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c2abfb19c1a
Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e855a23cef4
Fix eslint failures for trailing spaces. r=eslint-fix

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/2c2abfb19c1a
https://hg.mozilla.org/mozilla-central/rev/2e855a23cef4

Comment 5

[Andrei Lazar]

Comment on attachment 9024759 [details]
Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1501688

User impact if declined: Cache clearing won't work.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: Yes

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): It's pretty standalone and won't affect other components

String changes made/needed: -

Comment 6

[Ryan VanderMeulen [:RyanVM]]

(In reply to Andrei Lazar from comment #5)
> Feature/Bug causing the regression: Bug 1501688

I assume bug 1499618 was intended here.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9024759 [details]
Bug 1501688 Temporary files generated by opening external files with content:// scheme should be sanitized r=JanH

[Triage Comment]
Fixes broken cache clearing in Fennec 65. Approved for 65.0b4.

Comment 8

[Jan Henning [:JanH]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)
> (In reply to Andrei Lazar from comment #5)
> > Feature/Bug causing the regression: Bug 1501688
> 
> I assume bug 1499618 was intended here.

Correct.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e2336587275f

Comment 10

[Sorina Florean [:sflorean]]

Tested this with the help of Andrei on a Nightly debuggable build who has the patch included. The folder ContentUri was deleted if we performed a clear cache from settings. Seems that we can't test on 65 Beta due to the fact that bug 1506649 is not fixed yet. I will mark 66: verified and keep the qe-verify flag to test when bug 1506649 is landed.

Comment 11

[Ioana Chiorean]

Seems there is a fix for bug 1506649 - Sorina can you check it again pls?

Comment 12

[Sorina Florean [:sflorean]]

Verified as fixed on 66.0b3.
Device: HTC Desire 820(Android 6.0.1).