1499618 - Crash in java.lang.IllegalArgumentException: at android.database.AbstractCursor.getColumnIndexOrThrow(AbstractCursor.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect, P1)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-3bf6035f-60da-4df1-863f-72d990181017.
=============================================================

Java stack trace:

java.lang.IllegalArgumentException
	at android.database.AbstractCursor.getColumnIndexOrThrow(AbstractCursor.java:333)
	at android.database.CursorWrapper.getColumnIndexOrThrow(CursorWrapper.java:87)
	at org.mozilla.gecko.util.ContentUriUtils.getDataColumn(ContentUriUtils.java:135)
	at org.mozilla.gecko.util.ContentUriUtils.getPath(ContentUriUtils.java:101)
	at org.mozilla.gecko.util.FileUtils.getFilePathFromUri(FileUtils.java:291)
	at org.mozilla.gecko.IntentHelper.openNoHandler(IntentHelper.java:504)
	at org.mozilla.gecko.IntentHelper.handleMessage(IntentHelper.java:416)
	at org.mozilla.gecko.EventDispatcher$3.run(EventDispatcher.java:356)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6351)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:896)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:786)

There are 8 crashes (from 4 installations) in nightly 64 with buildid 20181016100107. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1406903.

[1] https://hg.mozilla.org/mozilla-central/rev?node=05d8e65ff651

Comment 1

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Samsung Galaxy S7 (8);
 - Nexus 6P (8.1.0);
 - OnePlus 5T (8.1.0);
 - Nokia 6 (7.1.1);
 - Google Pixel (9);
 - Huawei P9 Lite (6);
 - Huawei MediaPad M2 (5.1.1).

Hello, 

Tested in the following scenarios:
 - Update Nightly using the Play Store and launch;
 - Uninstall and reinstall Nightly from the Play Store;
 - Uninstall and install Nightly from the archive;
 - Steps from Bug 1406903 Comment 0.

In none of these scenarios did Nightly crash on any of the devices I've tested this with. Will continue investigating and come back if anything of relevance pops up.

Comment 2

[Andrei Lazar]

Attachment: Bug 1499618 Crash in java.lang.IllegalArgumentException: at android.database.AbstractCursor.getColumnIndexOrThrow(AbstractCursor.java) r=JanH

Added fallback for the cases where trying to obtain a file absolute path from external storage was throwing an exception.

Comment 3

[Marcia Knous [:marcia]]

This is the #3 top crash in Fennec 64b3.

Comment 4

[Jan Henning [:JanH]]

Maybe we should just backout bug 1406903 from Beta to give this feature one more version to stabilise?

Comment 5

[Marcia Knous [:marcia]]

(In reply to Jan Henning [:JanH] from comment #4)
> Maybe we should just backout bug 1406903 from Beta to give this feature one
> more version to stabilise?

Given the fact that we now have two regressions, this bug and Bug 1502721 it might not be a bad idea. Julien - thoughts?

Comment 6

[Julien Cristau [:jcristau]]

Sounds reasonable to me.

Comment 7

[Jan Henning [:JanH]]

Backed out from Beta: https://hg.mozilla.org/releases/mozilla-beta/rev/194d3585f3d567c047245c842ac5ee6b6390b474

Comment 8

[Jan Henning [:JanH]]

That was an r+ with comments.

Comment 9

[Jan Henning [:JanH]]

Seeing that Andrei is away, until next week, I'll fix them and push this myself.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e1e05cf314a3
Crash in java.lang.IllegalArgumentException: at android.database.AbstractCursor.getColumnIndexOrThrow(AbstractCursor.java) r=JanH

Comment 11

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/e1e05cf314a3