Closed Bug 1501734 Opened 6 years ago Closed 6 years ago

Enable streams by default in the JS shell

Categories

(Core :: JavaScript Engine, enhancement, P1)

Product:
Core
Component:
JavaScript Engine
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: jorendorff, Assigned: jorendorff)

References

Details

Attachments

(1 file)

Bug 1501734 - Enable streams by default in the JS shell. r?tcampbell
46 bytes, text/x-phabricator-request
Details | Review
No description provided.
Bug 1389628 will enable streams for everyone by default. It still has a few blockers. But we might as well do this part right now.
Attachment #9019756 - Flags: feedback?(nth10sd)
Attachment #9019756 - Flags: feedback?(choller)
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3db828b6494a Enable streams by default in the JS shell. r=tcampbell
Backed out changeset 3db828b6494a (bug 1501734) for spidermonkey failures Log: https://treeherder.mozilla.org/logviewer.html#?job_id=207747472&repo=autoland&lineNumber=17628 TEST-PASS | js/src/jit-test/tests/basic/bug1420961.js | Success (code 0, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.0 s] [task 2018-10-25T11:35:49.948Z] {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 11414, "source": "jittests", "test": "basic/bug1420961.js", "thread": "main", "time": 1540467349.9088209} [task 2018-10-25T11:35:49.948Z] {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 11414}, "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "message": "Success", "pid": 11414, "source": "jittests", "status": "PASS", "test": "basic/bug1420961.js", "thread": "main", "time": 1540467349.947893} [task 2018-10-25T11:35:49.955Z] /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.955Z] Stack: [task 2018-10-25T11:35:49.955Z] assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.955Z] @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.955Z] Exit code: 3 [task 2018-10-25T11:35:49.955Z] FAIL - basic/bug1445854.js [task 2018-10-25T11:35:49.955Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/bug1445854.js | /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown (code 3, args "--ion-eager --ion-offthread-compile=off") [0.0 s] [task 2018-10-25T11:35:49.956Z] {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off", "pid": 11420, "source": "jittests", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.919127} [task 2018-10-25T11:35:49.956Z] {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off", "pid": 11420}, "jitflags": "--ion-eager --ion-offthread-compile=off", "message": "/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown", "pid": 11420, "source": "jittests", "status": "FAIL", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.955747} [task 2018-10-25T11:35:49.956Z] INFO exit-status : 3 [task 2018-10-25T11:35:49.956Z] INFO timed-out : False [task 2018-10-25T11:35:49.956Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.956Z] INFO stderr 2> Stack: [task 2018-10-25T11:35:49.956Z] INFO stderr 2> assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.956Z] INFO stderr 2> @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.959Z] TEST-PASS | js/src/jit-test/tests/basic/bug1420961.js | Success (code 0, args "--baseline-eager") [0.0 s] [task 2018-10-25T11:35:49.959Z] {"action": "test_start", "jitflags": "--baseline-eager", "pid": 11415, "source": "jittests", "test": "basic/bug1420961.js", "thread": "main", "time": 1540467349.91219} [task 2018-10-25T11:35:49.959Z] {"action": "test_end", "extra": {"jitflags": "--baseline-eager", "pid": 11415}, "jitflags": "--baseline-eager", "message": "Success", "pid": 11415, "source": "jittests", "status": "PASS", "test": "basic/bug1420961.js", "thread": "main", "time": 1540467349.959122} [task 2018-10-25T11:35:49.959Z] TEST-PASS | js/src/jit-test/tests/basic/bug1420961.js | Success (code 0, args "--no-baseline --no-ion") [0.0 s] [task 2018-10-25T11:35:49.959Z] {"action": "test_start", "jitflags": "--no-baseline --no-ion", "pid": 11416, "source": "jittests", "test": "basic/bug1420961.js", "thread": "main", "time": 1540467349.914474} [task 2018-10-25T11:35:49.959Z] {"action": "test_end", "extra": {"jitflags": "--no-baseline --no-ion", "pid": 11416}, "jitflags": "--no-baseline --no-ion", "message": "Success", "pid": 11416, "source": "jittests", "status": "PASS", "test": "basic/bug1420961.js", "thread": "main", "time": 1540467349.959493} [task 2018-10-25T11:35:49.959Z] /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.959Z] Stack: [task 2018-10-25T11:35:49.959Z] assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.959Z] @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.959Z] Exit code: 3 [task 2018-10-25T11:35:49.959Z] FAIL - basic/bug1445854.js [task 2018-10-25T11:35:49.959Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/bug1445854.js | /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown (code 3, args "") [0.0 s] [task 2018-10-25T11:35:49.959Z] {"action": "test_start", "jitflags": "", "pid": 11418, "source": "jittests", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.9169521} [task 2018-10-25T11:35:49.960Z] {"action": "test_end", "extra": {"jitflags": "", "pid": 11418}, "jitflags": "", "message": "/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown", "pid": 11418, "source": "jittests", "status": "FAIL", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.959865} [task 2018-10-25T11:35:49.960Z] INFO exit-status : 3 [task 2018-10-25T11:35:49.960Z] INFO timed-out : False [task 2018-10-25T11:35:49.960Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.960Z] INFO stderr 2> Stack: [task 2018-10-25T11:35:49.960Z] INFO stderr 2> assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.960Z] INFO stderr 2> @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.966Z] /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.966Z] Stack: [task 2018-10-25T11:35:49.966Z] assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.966Z] @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.966Z] Exit code: 3 [task 2018-10-25T11:35:49.966Z] FAIL - basic/bug1445854.js [task 2018-10-25T11:35:49.966Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/bug1445854.js | /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown (code 3, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.0 s] [task 2018-10-25T11:35:49.970Z] {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 11438, "source": "jittests", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.923238} [task 2018-10-25T11:35:49.970Z] {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 11438}, "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "message": "/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown", "pid": 11438, "source": "jittests", "status": "FAIL", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.966507} [task 2018-10-25T11:35:49.970Z] INFO exit-status : 3 [task 2018-10-25T11:35:49.970Z] INFO timed-out : False [task 2018-10-25T11:35:49.970Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.970Z] INFO stderr 2> Stack: [task 2018-10-25T11:35:49.970Z] INFO stderr 2> assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.970Z] INFO stderr 2> @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.975Z] /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.975Z] Stack: [task 2018-10-25T11:35:49.975Z] assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.975Z] @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.975Z] Exit code: 3 [task 2018-10-25T11:35:49.975Z] FAIL - basic/bug1445854.js [task 2018-10-25T11:35:49.975Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/bug1445854.js | /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown (code 3, args "--baseline-eager") [0.0 s] [task 2018-10-25T11:35:49.975Z] {"action": "test_start", "jitflags": "--baseline-eager", "pid": 11458, "source": "jittests", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.934853} [task 2018-10-25T11:35:49.975Z] {"action": "test_end", "extra": {"jitflags": "--baseline-eager", "pid": 11458}, "jitflags": "--baseline-eager", "message": "/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown", "pid": 11458, "source": "jittests", "status": "FAIL", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.975331} [task 2018-10-25T11:35:49.975Z] INFO exit-status : 3 [task 2018-10-25T11:35:49.975Z] INFO timed-out : False [task 2018-10-25T11:35:49.975Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.975Z] INFO stderr 2> Stack: [task 2018-10-25T11:35:49.975Z] INFO stderr 2> assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.975Z] INFO stderr 2> @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.977Z] TEST-PASS | js/src/jit-test/tests/basic/bug1447996.js | Success (code 59, args "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads") [0.0 s] [task 2018-10-25T11:35:49.978Z] {"action": "test_start", "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 11486, "source": "jittests", "test": "basic/bug1447996.js", "thread": "main", "time": 1540467349.947613} [task 2018-10-25T11:35:49.978Z] {"action": "test_end", "extra": {"jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "pid": 11486}, "jitflags": "--ion-eager --ion-offthread-compile=off --ion-check-range-analysis --ion-extra-checks --no-sse3 --no-threads", "message": "Success", "pid": 11486, "source": "jittests", "status": "PASS", "test": "basic/bug1447996.js", "thread": "main", "time": 1540467349.977995} [task 2018-10-25T11:35:49.980Z] /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.980Z] Stack: [task 2018-10-25T11:35:49.980Z] assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.980Z] @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.980Z] Exit code: 3 [task 2018-10-25T11:35:49.980Z] FAIL - basic/bug1445854.js [task 2018-10-25T11:35:49.980Z] TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/basic/bug1445854.js | /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown (code 3, args "--no-baseline --no-ion") [0.0 s] [task 2018-10-25T11:35:49.981Z] {"action": "test_start", "jitflags": "--no-baseline --no-ion", "pid": 11459, "source": "jittests", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.9386778} [task 2018-10-25T11:35:49.981Z] {"action": "test_end", "extra": {"jitflags": "--no-baseline --no-ion", "pid": 11459}, "jitflags": "--no-baseline --no-ion", "message": "/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown", "pid": 11459, "source": "jittests", "status": "FAIL", "test": "basic/bug1445854.js", "thread": "main", "time": 1540467349.981001} [task 2018-10-25T11:35:49.981Z] INFO exit-status : 3 [task 2018-10-25T11:35:49.981Z] INFO timed-out : False [task 2018-10-25T11:35:49.981Z] INFO stderr 2> /builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 Error: Assertion failed: expected exception , no exception thrown [task 2018-10-25T11:35:49.981Z] INFO stderr 2> Stack: [task 2018-10-25T11:35:49.981Z] INFO stderr 2> assertThrowsInstanceOf@/builds/worker/workspace/build/src/js/src/jit-test/lib/../../tests/non262/shell.js:148:13 [task 2018-10-25T11:35:49.981Z] INFO stderr 2> @/builds/worker/workspace/build/src/js/src/jit-test/tests/basic/bug1445854.js:3:5 [task 2018-10-25T11:35:49.981Z] TEST-PASS | js/src/jit-test/tests/basic/bug1447996.js | Success (code 59, args "--ion-eager --ion-offthread-compile=off") [0.0 s] Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&revision=3db828b6494a0f680310fb453a71f00fbb505bb3 Backout: https://hg.mozilla.org/integration/autoland/rev/0fc121f7a403b4dfef2efc11a48da848f60bd473
Flags: needinfo?(jorendorff)
Oh, that test is broken. Bug 1389628 part 1 has the fix; it needs to land first. Relanding.
Flags: needinfo?(jorendorff)
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c6a8b4d451af Enable streams by default in the JS shell. r=tcampbell
Priority: -- → P1
https://hg.mozilla.org/mozilla-central/rev/c6a8b4d451af
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Assignee: nobody → jorendorff
Comment on attachment 9019756 [details] Bug 1501734 - Enable streams by default in the JS shell. r?tcampbell funfuzz is now ready for --no-streams as per https://git.io/fxQ6J
Attachment #9019756 - Flags: feedback?(nth10sd)
(clearing feedback flag as it has already landed on m-c, but thanks for letting us know)
Attachment #9019756 - Flags: feedback?(choller)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: