Closed Bug 1501877 Opened Last year Closed Last year

Remove errant .only() from about-studies tests

Categories

(Firefox :: Normandy Client, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 65
Tracking Status
firefox64 --- fixed
firefox65 --- fixed

People

(Reporter: mythmon, Assigned: mythmon)

References

Details

Attachments

(1 file)

In the about studies tests, one of the tasks is marked as .only(), which disables all the other tests in the file. That's not right.
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae8cdf156f9a
Remove errant .only() from about:studies tests. r=Gijs
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d08c28ed42f1
Backed out 2 changesets (bug 1501877, bug 1498940) for failing browser_about_studies.js CLOSED TREE
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73fb7d7b85a3
Remove errant .only() from about:studies tests. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/73fb7d7b85a3
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Flags: needinfo?(mcooper)
Blocks: 1502169
Comment on attachment 9019888 [details]
Bug 1501877 - Remove errant .only() from about:studies tests. r=Gijs

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Unknown

User impact if declined: Tests were disabled, causing the code they were testing to fail silently.

Is this code covered by automated tests?: Yes

Has the fix been verified in Nightly?: No

Needs manual test from QE?: No

If yes, steps to reproduce: 

List of other uplifts needed: None

Risk to taking this patch: Medium

Why is the change risky/not risky? (and alternatives if risky): By re-enabling these tests, some intermittent test failures may have been exposed. This change doesn't expose any new issues to users though.

String changes made/needed:
Attachment #9019888 - Flags: approval-mozilla-beta?
Comment on attachment 9019888 [details]
Bug 1501877 - Remove errant .only() from about:studies tests. r=Gijs

[Triage Comment]
Needed for bug 1498940, approved for 64.0b6.
Attachment #9019888 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Marking as qe- per c#7.
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.