Closed
Bug 1501877
Opened 6 years ago
Closed 6 years ago
Remove errant .only() from about-studies tests
Categories
(Firefox :: Normandy Client, defect)
Firefox
Normandy Client
Tracking
()
RESOLVED
FIXED
Firefox 65
People
(Reporter: mythmon, Assigned: mythmon)
References
Details
Attachments
(1 file)
46 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
In the about studies tests, one of the tasks is marked as .only(), which disables all the other tests in the file. That's not right.
Assignee | ||
Comment 1•6 years ago
|
||
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ae8cdf156f9a
Remove errant .only() from about:studies tests. r=Gijs
Backout by aciure@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d08c28ed42f1
Backed out 2 changesets (bug 1501877, bug 1498940) for failing browser_about_studies.js CLOSED TREE
Comment 4•6 years ago
|
||
Backed out 2 changesets (bug 1501877, bug 1498940) for failing browser_about_studies.js
push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f0ed99b29aafb5fd7f613a000634b53927af4259&selectedJob=207819106
failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel%2Crunnable&revision=f0ed99b29aafb5fd7f613a000634b53927af4259&selectedJob=207819106&searchStr=linux%2Cx64%2Cdebug%2Cmochitests%2Cwith%2Ce10s%2Ctest-linux64%2Fdebug-mochitest-browser-chrome-e10s-4%2Cm-e10s%28bc4%29
backout: https://hg.mozilla.org/integration/autoland/rev/d08c28ed42f1bef0b77d38064759b797f377a998
Flags: needinfo?(mcooper)
Pushed by mcooper@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/73fb7d7b85a3
Remove errant .only() from about:studies tests. r=Gijs
Comment 6•6 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(mcooper)
Assignee | ||
Comment 7•6 years ago
|
||
Comment on attachment 9019888 [details]
Bug 1501877 - Remove errant .only() from about:studies tests. r=Gijs
[Beta/Release Uplift Approval Request]
Feature/Bug causing the regression: Unknown
User impact if declined: Tests were disabled, causing the code they were testing to fail silently.
Is this code covered by automated tests?: Yes
Has the fix been verified in Nightly?: No
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Medium
Why is the change risky/not risky? (and alternatives if risky): By re-enabling these tests, some intermittent test failures may have been exposed. This change doesn't expose any new issues to users though.
String changes made/needed:
Attachment #9019888 -
Flags: approval-mozilla-beta?
Comment 8•6 years ago
|
||
Comment on attachment 9019888 [details]
Bug 1501877 - Remove errant .only() from about:studies tests. r=Gijs
[Triage Comment]
Needed for bug 1498940, approved for 64.0b6.
Attachment #9019888 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment 9•6 years ago
|
||
bugherder uplift |
status-firefox64:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•