Closed Bug 1501952 Opened 2 years ago Closed 2 years ago

Print preview always shows 30% scale when it is actually Shrink To Fit

Categories

(Toolkit :: Printing, defect, P1)

63 Branch
defect

Tracking

()

VERIFIED FIXED
mozilla65
Tracking Status
firefox-esr60 --- unaffected
firefox63 --- verified
firefox64 --- verified
firefox65 --- verified

People

(Reporter: gordon, Assigned: dao)

References

Details

(Keywords: regression)

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 10.0; rv:63.0) Gecko/20100101 Firefox/63.0

Steps to reproduce:

If I view a web page and select Print Preview the scale ALWAYS shows 30% even though it is actually giving me a Shrink To Fit. If I select 30% from the drop down menu the scale changes, proving it was NOT at 30% but was at Shrink To Fit.


Actual results:

Regardless of the print scale I select the drop down menu ALWAYS shows 30% next time but is actually performing Shrink To Fit. The default scale shown is WRONG, showing 30% when it is actually "Shrink To Fit". Naturally when you use the drop down menu to select Shrink To Fit nothing changes as this is already what is happening.


Expected results:

The print scale used to stay at the last value chosen and if Shrink To Fit was selected then this is what would have been shown in the closed drop down box.

On version 63.0 the print scale defaults to Shrink To Fit. I am happy with this rather than it sticking to the last scale set but it should show "Shrink To Fit" in the unopened drop down scale menu. Currently it shows 30% which is WRONG.
[Tracking Requested - why for this release]:
Status: UNCONFIRMED → NEW
Component: Untriaged → Print Preview
Ever confirmed: true
Keywords: regression
Product: Firefox → Core
Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=81f6183eff6587a4e57bfa02bb0c2df9ae9ba2ab&tochange=13ec544a537b1339d262b81845ab65802367d6dd

Regressed by:414ca83ed73f	Dão Gottwald — Bug 1473265 - Clean up print preview toolbar ids and classes. r=bgrins

@Dão, Your patch seems to cause the regression. Could you please look into this?
Blocks: 1473265
Flags: needinfo?(dao+bmo)
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Component: Print Preview → Printing
Flags: needinfo?(dao+bmo)
Product: Core → Toolkit
Priority: -- → P1
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0e96d6002321
Make mScaleCombobox point to the right element. r=bgrins
Flags: qe-verify+
Summary: The print dialogue always shows 30% scale when it is actually Shrink To Fit → Print preview always shows 30% scale when it is actually Shrink To Fit
https://hg.mozilla.org/mozilla-central/rev/0e96d6002321
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
Comment on attachment 9019975 [details]
Bug 1501952 - Make mScaleCombobox point to the right element. r?bgrins

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1473265

User impact if declined: see comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: see comment 0

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed:
Attachment #9019975 - Flags: approval-mozilla-beta?
Comment on attachment 9019975 [details]
Bug 1501952 - Make mScaleCombobox point to the right element. r?bgrins

Trivial fix for print preview, approved for 64.0b5.
Attachment #9019975 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
If the user has disabled Shrink to Fit and uses a standard or custom percentage -- which Firefox remembers -- the next use of Print Preview also will show 30% instead of the true value that will be used. It may be difficult for the average user to know what scale they used previously (they would need to open the Page Setup dialog).

Any chance of uplift if there is a Firefox 63.0.1?

SuMo thread: https://support.mozilla.org/questions/1238497
(In reply to jscher2000 from comment #9)
> Any chance of uplift if there is a Firefox 63.0.1?

Ryan?
Flags: needinfo?(ryanvm)
Seems like a decent candidate, though Fx63 is Pascal's release. Go ahead and nominate the patch for release uplift :).
Flags: needinfo?(ryanvm)
Comment on attachment 9019975 [details]
Bug 1501952 - Make mScaleCombobox point to the right element. r?bgrins

[Beta/Release Uplift Approval Request]

Feature/Bug causing the regression: Bug 1473265

User impact if declined: see comment 0

Is this code covered by automated tests?: No

Has the fix been verified in Nightly?: No

Needs manual test from QE?: Yes

If yes, steps to reproduce: see comment 0

List of other uplifts needed: None

Risk to taking this patch: Low

Why is the change risky/not risky? (and alternatives if risky): trivial fix

String changes made/needed:
Attachment #9019975 - Flags: approval-mozilla-release?
Status: RESOLVED → VERIFIED
Comment on attachment 9019975 [details]
Bug 1501952 - Make mScaleCombobox point to the right element. r?bgrins

Trivial fix for a regression, already uplifted to beta, approved for 63.0.1. Thanks
Attachment #9019975 - Flags: approval-mozilla-release? → approval-mozilla-release+
I have managed to reproduce this issue using Firefox 65.0a1 (BuildId:20181024221315) on Windows 10 64bit.

This issue is verified fixed using Firefox 63.0.1 (BuildId:20181030165643) on Windows 10 64bit and Ubuntu 16.04 64bit.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.