Closed Bug 1501955 Opened Last year Closed 9 months ago

Empty certificate section displayed when accessing More info in Control Centre > Connection from security error page

Categories

(Firefox :: Page Info Window, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: flod, Assigned: danielleleb12, Mentored)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Open for example https://myrelocation.com/register/Login.aspx

Then:
1) Click the i icon
2) Open the Connection panel
3) Click the more info button at the bottom

The "Website Identity" section is completely empty.
Priority: -- → P2

The bug here is that the securityOnLoad function is not called in pageInfo.js when we are on a certificate error page.

Why not? Because the PageInfoChild actor does not run on about: pages. It probably makes sense to keep it that way because there's a bunch of other stuff that PageInfoChild does that we don't want to do on about: pages.

How do we solve this then? The best way would probably be to check if the spec of browser.documentURI starts with "about:certerror" and call securityOnLoad manually (around here).

It would also be great to have a test!

Mentor: jhofmann

Hi,
If this hasn't been assigned yet, I'd really like to work on it.
And Can you please help me what needs to be fixed?

Hey paarmita1998, sorry, I sort of promised this to danielleleb12 over in bug 1489874. I'll left some instructions for you in bug 1503506 :)

Assignee: nobody → danielleleb12
Status: NEW → ASSIGNED

Hey johannh,

I think I've got it working, but I'm not sure - the link posted in the description is actually opening correctly now and is showing the Website Identity information and certificate (it wasn't when I first opened it - it was blank, as described), but when I open it in Chrome I'm still getting an invalid certificate error. Any suggestions?

Also, for the test, should that be put in tests/pageInfo/browser_pageinfo_security.js, or somewhere else?

Thanks again!

(In reply to danielleleb12 from comment #4)

Hey johannh,

I think I've got it working, but I'm not sure - the link posted in the description is actually opening correctly now and is showing the Website Identity information and certificate (it wasn't when I first opened it - it was blank, as described), but when I open it in Chrome I'm still getting an invalid certificate error. Any suggestions?

Hey, awesome! Hm, did you add an exception maybe? Otherwise, https://badssl.com/ has a great collection of other broken sites.

Also, for the test, should that be put in tests/pageInfo/browser_pageinfo_security.js, or somewhere else?

Yeah, that sounds like a reasonable place, let me know if you have questions about tests in Firefox, they can be a bit arcane. If you want to read up more about Mochitest there's a page here: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mochitest

When testing you'll have the following URLs available with broken certs: https://searchfox.org/mozilla-central/rev/00f3836a87b844b5e4bc82f698c559b9966e4be2/build/pgo/server-locations.txt#113-115

Thanks!

Something along the lines of https://badssl.com/ is exactly what I was looking for - thanks!

I'm creating the revision now (fixing the bug and adding the test), so you can take a look and let me know of any adjustments that should be made.

Thanks again for all the info!

Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/355c869b33e3
Runs securityOnLoad on certificate error pages and adds test. r=johannh

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Duplicate of this bug: 1538041
Duplicate of this bug: 432537
Depends on: 1535865
Duplicate of this bug: 1548936
You need to log in before you can comment on or make changes to this bug.