Improve error messages when trying to use dropped segments

RESOLVED FIXED in Firefox 66

Status

()

enhancement
P3
normal
RESOLVED FIXED
7 months ago
4 months ago

People

(Reporter: lth, Assigned: lth)

Tracking

(Blocks 1 bug)

Trunk
mozilla66
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox65 wontfix, firefox66 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

7 months ago
Supposedly active segments have been re-specified in terms of passive segment semantics, along the lines of "an active segment is equal to a mem.init + mem.drop" (ditto table) "running before the start function".  This needs to be investigated, and if there are implications for how we handle segments (eg, suppose mem.init is allowed to use an active segment for its source, then we must properly trap because that segment is gone) we must update the code.
Assignee

Updated

4 months ago
Assignee: nobody → lhansen
Status: NEW → ASSIGNED
Assignee

Comment 1

4 months ago

Pretty clean semantics here, for memory.init and here, for data.drop, with trapping behavior.

Assignee

Comment 2

4 months ago

So far as I can tell, our data structures have the correct semantics for this: the instance has an array of segments for the module, in which active segments are null to begin with and passive segments become null as they are dropped. Both memory.init and data.drop consult this table, and error out (as they should) if an element is null. Active segments are stored elsewhere (presumably the module) and the "implicit memory.init + data.drop" is just window dressing really.

We can however improve the error messages.

Assignee

Comment 3

4 months ago
Attachment #9038801 - Flags: review?(jseward)
Assignee

Updated

4 months ago
Summary: Bulk memory: Track proposal changes wrt active segments → Improve error messages when trying to use dropped segments
Comment on attachment 9038801 [details] [diff] [review]
bug1502037-dropped-segment-errors.patch

Review of attachment 9038801 [details] [diff] [review]:
-----------------------------------------------------------------

Looks pretty uncontroversial.
Attachment #9038801 - Flags: review?(jseward) → review+

Comment 5

4 months ago
Pushed by lhansen@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83097742e871
Better error messages when accessing dropped data/elem segments. r=jseward

Comment 6

4 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla66

Updated

4 months ago
See Also: → 1523081
You need to log in before you can comment on or make changes to this bug.