1502128 - Move existing old debugger tests to shared

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[David Walsh :davidwalsh]

There following tests need to be moved from the old debugger's test directory to the new one:

browser_dbg_promises-allocation-stack.js
browser_dbg_promises-chrome-allocation-stack.js
browser_dbg_promises-fulfillment-stack.js
browser_dbg_promises-rejection-stack.js
browser_dbg_terminate-on-tab-close.js

Along with assets:

doc_promise-get-allocation-stack.html
doc_promise-get-fulfillment-stack.html
doc_promise-get-rejection-stack.html
doc_terminate-on-tab-close.html

The functionality for these tests lives in:

https://hg.mozilla.org/mozilla-central/file/37d240a1d498/devtools/client/debugger/test/mochitest/head.js

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1502128 - Migrate promises actor tests to server tests.

MozReview-Commit-ID: JobfpedA88C

Comment 2

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1502128 - Remove last old debugger test.

This test is broken for a while as it doesn't wait for resumeDebuggerThenCloseAndFinish to finish...
If was trying to ensure that resumeDebuggerThenCloseAndFinish wasn't throwing.
The test is most about testing old debugger test helper rather than test a particular STR.

MozReview-Commit-ID: 3gAWOSxjFet

Depends on D13823

Comment 3

[Alexandre Poirot [:ochameau]]

try run:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8ed95a1031d29f814ea89365ea51551c614dbf7

Comment 4

[Alexandre Poirot [:ochameau]]

Flagging for fission as these tests are using listTabs, which I have to refactor for fission. And these promises tests were copy pasting a lot of code, including a call to listTabs.

Comment 5

[David Walsh :davidwalsh]

Try seems to believe the `browser_dbg_promises-fulfillment-stack.js` tests are failing.

Comment 6

[Alexandre Poirot [:ochameau]]

Oh I fixed some eslint issues which changed the line/column offset.
This one should be greener:
  https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b1bbd7a23918a3449ec89630d3dba2817b50aa6

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ff997a82197
Migrate promises actor tests to server tests. r=yulia
https://hg.mozilla.org/integration/autoland/rev/1a38b65dd51f
Remove last old debugger test. r=davidwalsh

Comment 8

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/8ff997a82197
https://hg.mozilla.org/mozilla-central/rev/1a38b65dd51f