Closed
Bug 1502128
Opened 6 years ago
Closed 6 years ago
Move existing old debugger tests to shared
Categories
(DevTools :: Debugger, defect, P3)
DevTools
Debugger
Tracking
(firefox66 fixed)
RESOLVED
FIXED
Firefox 66
Tracking | Status | |
---|---|---|
firefox66 | --- | fixed |
People
(Reporter: davidwalsh, Assigned: ochameau)
References
Details
(Whiteboard: dt-fission)
Attachments
(2 files)
There following tests need to be moved from the old debugger's test directory to the new one:
browser_dbg_promises-allocation-stack.js
browser_dbg_promises-chrome-allocation-stack.js
browser_dbg_promises-fulfillment-stack.js
browser_dbg_promises-rejection-stack.js
browser_dbg_terminate-on-tab-close.js
Along with assets:
doc_promise-get-allocation-stack.html
doc_promise-get-fulfillment-stack.html
doc_promise-get-rejection-stack.html
doc_terminate-on-tab-close.html
The functionality for these tests lives in:
https://hg.mozilla.org/mozilla-central/file/37d240a1d498/devtools/client/debugger/test/mochitest/head.js
Updated•6 years ago
|
Priority: -- → P3
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → poirot.alex
Assignee | ||
Comment 1•6 years ago
|
||
MozReview-Commit-ID: JobfpedA88C
Assignee | ||
Comment 2•6 years ago
|
||
This test is broken for a while as it doesn't wait for resumeDebuggerThenCloseAndFinish to finish...
If was trying to ensure that resumeDebuggerThenCloseAndFinish wasn't throwing.
The test is most about testing old debugger test helper rather than test a particular STR.
MozReview-Commit-ID: 3gAWOSxjFet
Depends on D13823
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Comment 4•6 years ago
|
||
Flagging for fission as these tests are using listTabs, which I have to refactor for fission. And these promises tests were copy pasting a lot of code, including a call to listTabs.
Blocks: 1508285
Whiteboard: dt-fission
Reporter | ||
Comment 5•6 years ago
|
||
Try seems to believe the `browser_dbg_promises-fulfillment-stack.js` tests are failing.
Assignee | ||
Comment 6•6 years ago
|
||
Oh I fixed some eslint issues which changed the line/column offset.
This one should be greener:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4b1bbd7a23918a3449ec89630d3dba2817b50aa6
Pushed by apoirot@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ff997a82197
Migrate promises actor tests to server tests. r=yulia
https://hg.mozilla.org/integration/autoland/rev/1a38b65dd51f
Remove last old debugger test. r=davidwalsh
Comment 8•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8ff997a82197
https://hg.mozilla.org/mozilla-central/rev/1a38b65dd51f
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox66:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 66
You need to log in
before you can comment on or make changes to this bug.
Description
•