Closed Bug 1502151 Opened 7 years ago Closed 7 years ago

Stop using document.getElementById to get elements from inside XBL anon content for browser-search-autocomplete-result-popup

Categories

(Firefox :: Search, enhancement)

Product:
Firefox
Component:
Search
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: bgrins, Assigned: bgrins)

References

Details

Attachments

(1 file)

Bug 1502151 Use getAnonymousElementByAttribute instead of elementById to reach into XBL anon content for browser-search-autocomplete-result-popup;r=dao
46 bytes, text/x-phabricator-request
Details | Review
This breaks browser.xhtml for the same reason that Bug 1500240 did.
I think this covers the following test failures: browser/components/search/test/browser_oneOffContextMenu_setDefault.js browser/components/search/test/browser_oneOffHeader.js browser/components/search/test/browser_private_search_perwindowpb.js browser/components/search/test/browser_searchEngine_behaviors.js browser/components/search/test/browser_searchbar_keyboard_navigation.js
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f48407f1568b Use getAnonymousElementByAttribute instead of elementById to reach into XBL anon content for browser-search-autocomplete-result-popup;r=dao
https://hg.mozilla.org/mozilla-central/rev/f48407f1568b
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: